fix: add max prunes to pruner by MasterPtato · Pull Request #4191 · rivet-dev/rivet

MasterPtato · 2026-02-12T22:50:47Z

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

railway-app · 2026-02-12T22:50:54Z

🚅 Deployed to the rivet-pr-4191 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
ladle	❌ Build Failed (View Logs)	Web	Feb 19, 2026 at 10:54 pm
website	😴 Sleeping (View Logs)	Web	Feb 16, 2026 at 7:46 am
frontend-inspector	❌ Build Failed (View Logs)	Web	Feb 12, 2026 at 10:52 pm
frontend-cloud	❌ Build Failed (View Logs)	Web	Feb 12, 2026 at 10:52 pm
mcp-hub	✅ Success (View Logs)	Web	Feb 12, 2026 at 10:51 pm

MasterPtato · 2026-02-12T22:51:08Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

fix(gas): gracefully handle corrupt wf #4220 : 2 dependent PRs (#4234 , #4235 )
chore: improve debugging for runners #4219
fix: add max prunes to pruner #4191 👈 (View in Graphite)
fix: add max param to prune signals cmd #4190
fix: reduce metrics aggregator cardinality #4183
fix: docker cache issues, dashboards #4181
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

claude · 2026-02-12T22:53:50Z

PR Review: fix: add max prunes to pruner

Overall: Small, well-targeted fix. The logic is correct and addresses a real risk of unbounded transaction sizes in the pruner.

What the change does

The pruner loops over FDB key ranges inside transactions and deletes workflow data. Before this fix, a single transaction could process an unlimited number of entries, bounded only by the 3-second EARLY_TXN_TIMEOUT. This PR adds a hard cap of 1000 prunes per transaction, preventing large transactions that could hit FDB's write limits.

Correctness

The pagination logic is sound. When the inner loop breaks due to hitting the limit, new_last_key is already set to [entry.key(), &[0xff]].concat() — the standard FDB exclusive-start key for resuming from the next entry. The outer loop picks this up via last_key = new_last_key and continues correctly from that point. No entries are skipped or double-processed.

One pre-existing nuance: the PruneVariant::None => continue branch deletes the index entry but does not increment prune_count or update new_last_key. This means None variants don't count toward the per-transaction cap and don't advance the pagination cursor. In practice this is fine since None variants are pruned in-line, but worth keeping in mind if the None case ever changes.

Observations

StreamingMode::WantAll interaction: The range query uses WantAll, which asks FDB to return all matching keys in one batch. The break stops loop processing at 1000, but the network fetch may already have retrieved more keys. This is a minor efficiency concern (extra data transferred) but not a correctness issue — the transaction's write buffer is correctly bounded by the 1000-entry limit.

Timeout interaction (pre-existing): When EARLY_TXN_TIMEOUT fires before any entry is processed, new_last_key remains Vec::new(), which causes the outer loop to terminate early at line 1401. Prune work could be silently incomplete in that case. Not introduced here, but worth flagging.

Magic number: The value 1000 is reasonable but has no comment explaining the rationale (e.g. staying well within FDB's 10 MB transaction write limit). A brief inline comment would help future readers.

Summary

Category	Assessment
Correctness	Pagination resumes correctly after hitting the limit
Performance	Prevents oversized transactions; minor WantAll over-fetch is acceptable
Security	No concerns
Tests	No new tests; acceptable for a defensive internal guard

The core fix is solid. The observations above are all pre-existing issues or minor nits that do not block the change.

pkg-pr-new · 2026-02-18T02:16:30Z

More templates

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4191

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4191

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4191

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4191

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4191

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4191

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4191

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4191

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4191

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4191

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4191

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4191

commit: c37f972

graphite-app · 2026-02-19T22:54:15Z

Merge activity

Feb 19, 10:54 PM UTC: MasterPtato added this pull request to the Graphite merge queue.
Feb 19, 10:54 PM UTC: CI is running for this pull request on a draft pull request (#4241) due to your merge queue CI optimization settings.
Feb 19, 10:55 PM UTC: Merged by the Graphite merge queue via draft PR: #4241.

# Description Please include a summary of the changes and the related issue. Please also include relevant motivation and context. ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update ## How Has This Been Tested? Please describe the tests that you ran to verify your changes. ## Checklist: - [ ] My code follows the style guidelines of this project - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] New and existing unit tests pass locally with my changes

MasterPtato requested a review from NathanFlurry February 12, 2026 22:50

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 12, 2026 22:50 Destroyed

This was referenced Feb 12, 2026

fix: docker cache issues, dashboards #4181

Closed

fix: reduce metrics aggregator cardinality #4183

Closed

fix: add max param to prune signals cmd #4190

Closed

MasterPtato force-pushed the 02-12-fix_add_max_param_to_prune_signals_cmd branch from 6d76467 to d19b48a Compare February 18, 2026 02:13

MasterPtato force-pushed the 02-12-fix_add_max_prunes_to_pruner branch from 832c05a to 6804587 Compare February 18, 2026 02:13

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 18, 2026 02:13 Destroyed

This was referenced Feb 18, 2026

chore: improve debugging for runners #4219

Closed

fix(gas): gracefully handle corrupt wf #4220

Closed

graphite-app bot force-pushed the 02-12-fix_add_max_param_to_prune_signals_cmd branch from d19b48a to 9f9271d Compare February 18, 2026 02:28

graphite-app bot force-pushed the 02-12-fix_add_max_prunes_to_pruner branch from 6804587 to 9561940 Compare February 18, 2026 02:29

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 18, 2026 02:29 Destroyed

MasterPtato force-pushed the 02-12-fix_add_max_param_to_prune_signals_cmd branch from 9f9271d to dbb33f8 Compare February 19, 2026 20:46

MasterPtato force-pushed the 02-12-fix_add_max_prunes_to_pruner branch from 9561940 to 1ae21ab Compare February 19, 2026 20:46

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 19, 2026 20:46 Destroyed

This was referenced Feb 19, 2026

fix(epoxy): make quorum sizes match paper #4234

Open

fix(serverless): include entire error chain in msg #4235

Closed

MasterPtato force-pushed the 02-12-fix_add_max_prunes_to_pruner branch from 1ae21ab to c37f972 Compare February 19, 2026 22:41

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 19, 2026 22:41 Destroyed

MasterPtato force-pushed the 02-12-fix_add_max_prunes_to_pruner branch from c37f972 to 603d888 Compare February 19, 2026 22:51

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 19, 2026 22:51 Destroyed

fix: add max prunes to pruner

1e27716

MasterPtato force-pushed the 02-12-fix_add_max_param_to_prune_signals_cmd branch from dbb33f8 to 8f1ddf6 Compare February 19, 2026 22:53

MasterPtato force-pushed the 02-12-fix_add_max_prunes_to_pruner branch from 603d888 to 1e27716 Compare February 19, 2026 22:53

railway-app bot temporarily deployed to rivet-frontend / rivet-pr-4191 February 19, 2026 22:53 Destroyed

graphite-app bot closed this Feb 19, 2026

graphite-app bot deleted the 02-12-fix_add_max_prunes_to_pruner branch February 19, 2026 22:55

claude bot mentioned this pull request Feb 19, 2026

[Graphite MQ] Draft PR GROUP:spec_3b0cac (PRs 4183, 4190, 4191, 4219, 4220, 4235) #4241

Closed

This was referenced Feb 20, 2026

chore: get docker compose working again #4246

Open

fix(pegboard): add threshold parameters to runner protocol metadata #4247

Open

fix(guard, runner): enforce http body size and ws msg size #4252

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

fix: add max prunes to pruner#4191

fix: add max prunes to pruner#4191
MasterPtato wants to merge 1 commit into02-12-fix_add_max_param_to_prune_signals_cmdfrom
02-12-fix_add_max_prunes_to_pruner

MasterPtato commented Feb 12, 2026

Uh oh!

railway-app bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

MasterPtato commented Feb 12, 2026 •

edited

Loading

Uh oh!

claude bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Feb 18, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Feb 19, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Comments

Conversation

MasterPtato commented Feb 12, 2026

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

railway-app bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

claude bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Review: fix: add max prunes to pruner

What the change does

Correctness

Observations

Summary

Uh oh!

pkg-pr-new bot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Feb 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

railway-app bot commented Feb 12, 2026 •

edited

Loading

MasterPtato commented Feb 12, 2026 •

edited

Loading

claude bot commented Feb 12, 2026 •

edited

Loading

pkg-pr-new bot commented Feb 18, 2026 •

edited

Loading

graphite-app bot commented Feb 19, 2026 •

edited

Loading