Skip to content

Comments

chore: get docker compose working again#4246

Open
MasterPtato wants to merge 1 commit into02-19-fix_epoxy_make_quorum_sizes_match_paperfrom
02-19-chore_get_docker_compose_working_again
Open

chore: get docker compose working again#4246
MasterPtato wants to merge 1 commit into02-19-fix_epoxy_make_quorum_sizes_match_paperfrom
02-19-chore_get_docker_compose_working_again

Conversation

@MasterPtato
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@railway-app
Copy link

railway-app bot commented Feb 20, 2026

🚅 Deployed to the rivet-pr-4246 environment in rivet-frontend

Service Status Web Updated (UTC)
ladle ❌ Build Failed (View Logs) Web Feb 21, 2026 at 1:41 am
website 😴 Sleeping (View Logs) Web Feb 20, 2026 at 2:47 am
mcp-hub ✅ Success (View Logs) Web Feb 20, 2026 at 2:37 am
frontend-inspector ❌ Build Failed (View Logs) Web Feb 20, 2026 at 2:37 am
frontend-cloud ❌ Build Failed (View Logs) Web Feb 20, 2026 at 2:37 am

Copy link
Contributor Author

MasterPtato commented Feb 20, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Feb 20, 2026

PR Review: chore: get docker compose working again

Summary

This PR fixes several issues in the Docker development environment: Prometheus query syntax, Grafana dashboard metrics, Vector HTTP integration removal from engine config, and runner startup configuration. Overall the changes are well-targeted and correct, but there is one notable inconsistency to address.


Issues

Missing docker-compose.yml regeneration

The template engine/docker/template/src/docker-compose.ts was updated to add AUTOSTART_RUNNER=1 and AUTOCONFIGURE_SERVERLESS=0 to the runner service, but the generated docker-compose.yml files were not regenerated. The current engine/docker/dev/docker-compose.yml (and other variants) still show the runner without these env vars:

# Current state in docker-compose.yml (missing the new vars)
runner:
  environment:
    - RIVET_ENDPOINT=http://rivet-engine:6420
    - RIVET_RUNNER_TOTAL_SLOTS=1000000

Per CLAUDE.md: the config.jsonc files were regenerated (vector_http removed), but the docker-compose.yml files were not. If AUTOSTART_RUNNER is required for the fix, the dev environment will not actually work until someone regenerates. If it is not needed for the immediate fix, it is still worth making the generated files reflect the template to avoid drift.


Positive Changes

Prometheus label_values() syntax fix

All dashboards correctly move from the deprecated bare-label form to the metric-anchored form:

- label_values(rivet_project)
+ label_values(up, rivet_project)

This is required for newer Prometheus versions and prevents spurious "no data" in dashboard variables.

Gasoline dashboard deduplication logic

The new PromQL join pattern using rivet_gasoline_worker_last_metrics_publish to select only the most recently publishing worker pod is the right approach for preventing double-counting of gauge metrics across replicated worker instances. The logic is complex but appears correct.

Pegboard dashboard legend format fix

{{workflow_name}} was incorrectly used as the legend format for metrics aggregated by rivet_datacenter. The correction to {{rivet_datacenter}} is a clear bug fix.

Vector HTTP removal

The removal of vector_http and the ClickHouse provision_users.vector block is consistent between the template source (rivet-engine.ts) and all generated config.jsonc files. The Vector services themselves remain in docker-compose.yml, which is appropriate since they still serve other purposes via the otel-collector pipeline.

New dispatch rate panels in gasoline dashboard

Replacing the "Last Pull Workflows Duration" panels with stacked "Workflows Dispatched/s" panels provides more actionable throughput visibility. The separation between dispatches originating from workflows vs. non-workflow sources is a useful distinction.


Minor Notes

  • The pegboard dashboard default filter changed from prod to staging. This is probably intentional for dev environments, but worth confirming it will not affect production monitoring setups if these files are shared.
  • Default time range extended from 15m to 30m in gasoline.json — reasonable for workflow-level observability.
  • PR description is empty with all checklist items unchecked, which makes it harder to understand the full intent at a glance.

🤖 Generated with Claude Code

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 20, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@4246

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@4246

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@4246

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@4246

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@4246

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@4246

@rivetkit/sqlite-vfs

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sqlite-vfs@4246

@rivetkit/traces

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/traces@4246

@rivetkit/workflow-engine

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/workflow-engine@4246

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@4246

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@4246

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@4246

commit: 121bf70

@MasterPtato MasterPtato marked this pull request as ready for review February 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant