chore: improve debugging for runners#4219
chore: improve debugging for runners#4219MasterPtato wants to merge 1 commit into02-12-fix_add_max_prunes_to_prunerfrom
Conversation
|
🚅 Deployed to the rivet-pr-4219 environment in rivet-frontend
|
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR Review: chore: improve debugging for runnersOverall, this is a clean and focused PR that improves observability for the pegboard runner components. The changes are small, targeted, and follow the project's tracing conventions. A few notes below. Correctness
This is a genuine correctness fix, not just a style change. Tracing ImprovementsExplicit span names added ✅ Adding
Consistently adding Minor ObservationsIndentation in The added Indentation in Looking at the full file (e.g., lines 23-48), the function body appears to use 4-space indentation rather than hard tabs. This is pre-existing and not introduced by this PR, but it's worth noting if a formatting pass is planned.
This aligns the body indentation with the tree connector prefix for improved readability in the SummaryNo blocking issues. The correctness fix and observability improvements are solid. The PR is straightforward and ready for merge once the reviewer is satisfied. |
6804587 to
9561940
Compare
ba43d9d to
5a68f06
Compare

Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: