Skip to content

[fix](cloud) change cloud fe getVersion rpc metric to getTableVersion and getPartitionVersion #60745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mymeiyi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[fix](cloud) change cloud fe getVersion rpc metric to getTableVersion and getPartitionVersion #60745

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions fe/fe-core/src/main/java/org/apache/doris/cloud/rpc/MetaServiceProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,8 @@ private <Response> Response executeWithMetrics(String methodName, Function<MetaS
public Future<Cloud.GetVersionResponse> getVisibleVersionAsync(Cloud.GetVersionRequest request)
throws RpcException {
long startTime = System.currentTimeMillis();
String methodName = "getVersion";
String methodName = request.hasIsTableVersion() && request.getIsTableVersion() ? "getTableVersion"
: "getPartitionVersion";
MetaServiceClient client = null;

if (MetricRepo.isInit && Config.isCloudMode()) {
Expand Down Expand Up @@ -341,7 +342,9 @@ public void onFailure(Throwable t) {
}

public Cloud.GetVersionResponse getVersion(Cloud.GetVersionRequest request) throws RpcException {
return executeWithMetrics("getVersion", (client) -> client.getVersion(request));
String methodName = request.hasIsTableVersion() && request.getIsTableVersion() ? "getTableVersion"
: "getPartitionVersion";
return executeWithMetrics(methodName, (client) -> client.getVersion(request));
}

public Cloud.CreateTabletsResponse createTablets(Cloud.CreateTabletsRequest request) throws RpcException {
Expand Down
Loading