Skip to content

[fix](cloud) change cloud fe getVersion rpc metric to getTableVersion and getPartitionVersion#60745

Open
mymeiyi wants to merge 1 commit intoapache:masterfrom
mymeiyi:metrics-of-get-version
Open

[fix](cloud) change cloud fe getVersion rpc metric to getTableVersion and getPartitionVersion#60745
mymeiyi wants to merge 1 commit intoapache:masterfrom
mymeiyi:metrics-of-get-version

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Feb 13, 2026

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Copilot AI review requested due to automatic review settings February 13, 2026 10:37
@mymeiyi mymeiyi requested a review from w41ter as a code owner February 13, 2026 10:37
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Feb 13, 2026

run buildall

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves RPC metrics tracking for cloud mode by differentiating between table version and partition version queries. Previously, both types of version queries were tracked under a single "getVersion" metric, making it difficult to monitor and debug these operations separately.

Changes:

  • Modified getVisibleVersionAsync() to dynamically determine metric name based on isTableVersion field
  • Modified getVersion() to dynamically determine metric name based on isTableVersion field
  • Metrics now differentiate between "getTableVersion" and "getPartitionVersion" operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 20.00% (1/5) 🎉
Increment coverage report
Complete coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants