Skip to content

Reduce verbosity of StatsD connection errors #10618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PerfectSlayer wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

Reduce verbosity of StatsD connection errors #10618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...etrics/metrics-lib/src/main/java/datadog/metrics/impl/statsd/DDAgentStatsDConnection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,21 @@ private void doConnect() {
log.debug("Max retries have been reached. Will not attempt again.");
}
} catch (Throwable t) {
log.error("Unable to create StatsD client - {} - Will not retry", statsDAddress(), t);
if (log.isDebugEnabled()) {
// Display full stack traces on debug logs
log.warn("Unable to create StatsD client - {} - Will not retry", statsDAddress(), t);
} else {
// Only report the top and root cause message
Throwable rootCause = t;
while (rootCause.getCause() != null) {
rootCause = rootCause.getCause();
}
log.warn(
"Unable to create StatsD client - {} - Will not retry: {}, {}",
statsDAddress(),
t.getMessage(),
rootCause.getMessage());
}
}
}
}
Expand Down