Reduce verbosity of StatsD connection errors#10618
Open
PerfectSlayer wants to merge 1 commit intomasterfrom
Open
Reduce verbosity of StatsD connection errors#10618PerfectSlayer wants to merge 1 commit intomasterfrom
PerfectSlayer wants to merge 1 commit intomasterfrom
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.066 s) : 0, 1066239
Total [baseline] (8.728 s) : 0, 8728165
Agent [candidate] (1.066 s) : 0, 1066020
Total [candidate] (8.777 s) : 0, 8776637
section iast
Agent [baseline] (1.24 s) : 0, 1239706
Total [baseline] (9.356 s) : 0, 9356233
Agent [candidate] (1.232 s) : 0, 1231995
Total [candidate] (9.343 s) : 0, 9343406
gantt
title insecure-bank - break down per module: candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.196 ms) : 0, 1196
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (629.715 ms) : 0, 629715
BytebuddyAgent [candidate] (629.799 ms) : 0, 629799
AgentMeter [baseline] (28.98 ms) : 0, 28980
AgentMeter [candidate] (28.953 ms) : 0, 28953
GlobalTracer [baseline] (257.11 ms) : 0, 257110
GlobalTracer [candidate] (257.503 ms) : 0, 257503
AppSec [baseline] (32.74 ms) : 0, 32740
AppSec [candidate] (32.794 ms) : 0, 32794
Debugger [baseline] (60.903 ms) : 0, 60903
Debugger [candidate] (61.46 ms) : 0, 61460
Remote Config [baseline] (627.177 µs) : 0, 627
Remote Config [candidate] (615.529 µs) : 0, 616
Telemetry [baseline] (13.079 ms) : 0, 13079
Telemetry [candidate] (12.919 ms) : 0, 12919
Flare Poller [baseline] (6.509 ms) : 0, 6509
Flare Poller [candidate] (5.465 ms) : 0, 5465
section iast
crashtracking [baseline] (1.207 ms) : 0, 1207
crashtracking [candidate] (1.195 ms) : 0, 1195
BytebuddyAgent [baseline] (803.296 ms) : 0, 803296
BytebuddyAgent [candidate] (797.04 ms) : 0, 797040
AgentMeter [baseline] (11.516 ms) : 0, 11516
AgentMeter [candidate] (11.265 ms) : 0, 11265
GlobalTracer [baseline] (249.001 ms) : 0, 249001
GlobalTracer [candidate] (248.51 ms) : 0, 248510
IAST [baseline] (27.026 ms) : 0, 27026
IAST [candidate] (27.014 ms) : 0, 27014
AppSec [baseline] (33.09 ms) : 0, 33090
AppSec [candidate] (33.767 ms) : 0, 33767
Debugger [baseline] (66.544 ms) : 0, 66544
Debugger [candidate] (65.442 ms) : 0, 65442
Remote Config [baseline] (528.395 µs) : 0, 528
Remote Config [candidate] (528.722 µs) : 0, 529
Telemetry [baseline] (8.549 ms) : 0, 8549
Telemetry [candidate] (8.519 ms) : 0, 8519
Flare Poller [baseline] (3.459 ms) : 0, 3459
Flare Poller [candidate] (3.464 ms) : 0, 3464
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.065 s) : 0, 1064512
Total [baseline] (10.941 s) : 0, 10941434
Agent [candidate] (1.066 s) : 0, 1066112
Total [candidate] (10.952 s) : 0, 10951565
section appsec
Agent [baseline] (1.241 s) : 0, 1241480
Total [baseline] (10.982 s) : 0, 10981671
Agent [candidate] (1.24 s) : 0, 1240346
Total [candidate] (10.995 s) : 0, 10995011
section iast
Agent [baseline] (1.243 s) : 0, 1243033
Total [baseline] (11.132 s) : 0, 11132239
Agent [candidate] (1.234 s) : 0, 1234369
Total [candidate] (11.192 s) : 0, 11191715
section profiling
Agent [baseline] (1.202 s) : 0, 1201687
Total [baseline] (10.964 s) : 0, 10963946
Agent [candidate] (1.19 s) : 0, 1190015
Total [candidate] (10.947 s) : 0, 10946956
gantt
title petclinic - break down per module: candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.204 ms) : 0, 1204
BytebuddyAgent [baseline] (630.732 ms) : 0, 630732
BytebuddyAgent [candidate] (628.638 ms) : 0, 628638
AgentMeter [baseline] (28.933 ms) : 0, 28933
AgentMeter [candidate] (28.927 ms) : 0, 28927
GlobalTracer [baseline] (257.111 ms) : 0, 257111
GlobalTracer [candidate] (257.372 ms) : 0, 257372
AppSec [baseline] (32.791 ms) : 0, 32791
AppSec [candidate] (32.827 ms) : 0, 32827
Debugger [baseline] (60.857 ms) : 0, 60857
Debugger [candidate] (63.097 ms) : 0, 63097
Remote Config [baseline] (626.755 µs) : 0, 627
Remote Config [candidate] (617.748 µs) : 0, 618
Telemetry [baseline] (11.563 ms) : 0, 11563
Telemetry [candidate] (10.7 ms) : 0, 10700
Flare Poller [baseline] (5.3 ms) : 0, 5300
Flare Poller [candidate] (7.584 ms) : 0, 7584
section appsec
crashtracking [baseline] (1.183 ms) : 0, 1183
crashtracking [candidate] (1.199 ms) : 0, 1199
BytebuddyAgent [baseline] (660.271 ms) : 0, 660271
BytebuddyAgent [candidate] (659.22 ms) : 0, 659220
AgentMeter [baseline] (12.025 ms) : 0, 12025
AgentMeter [candidate] (12.003 ms) : 0, 12003
GlobalTracer [baseline] (258.78 ms) : 0, 258780
GlobalTracer [candidate] (258.244 ms) : 0, 258244
IAST [baseline] (25.28 ms) : 0, 25280
IAST [candidate] (25.386 ms) : 0, 25386
AppSec [baseline] (168.514 ms) : 0, 168514
AppSec [candidate] (167.494 ms) : 0, 167494
Debugger [baseline] (66.236 ms) : 0, 66236
Debugger [candidate] (67.337 ms) : 0, 67337
Remote Config [baseline] (644.202 µs) : 0, 644
Remote Config [candidate] (662.896 µs) : 0, 663
Telemetry [baseline] (9.605 ms) : 0, 9605
Telemetry [candidate] (9.701 ms) : 0, 9701
Flare Poller [baseline] (3.692 ms) : 0, 3692
Flare Poller [candidate] (3.773 ms) : 0, 3773
section iast
crashtracking [baseline] (1.186 ms) : 0, 1186
crashtracking [candidate] (1.179 ms) : 0, 1179
BytebuddyAgent [baseline] (803.354 ms) : 0, 803354
BytebuddyAgent [candidate] (797.727 ms) : 0, 797727
AgentMeter [baseline] (11.545 ms) : 0, 11545
AgentMeter [candidate] (11.315 ms) : 0, 11315
GlobalTracer [baseline] (249.79 ms) : 0, 249790
GlobalTracer [candidate] (248.487 ms) : 0, 248487
IAST [baseline] (27.341 ms) : 0, 27341
IAST [candidate] (26.956 ms) : 0, 26956
AppSec [baseline] (34.022 ms) : 0, 34022
AppSec [candidate] (33.971 ms) : 0, 33971
Debugger [baseline] (67.65 ms) : 0, 67650
Debugger [candidate] (66.925 ms) : 0, 66925
Remote Config [baseline] (548.154 µs) : 0, 548
Remote Config [candidate] (536.051 µs) : 0, 536
Telemetry [baseline] (8.663 ms) : 0, 8663
Telemetry [candidate] (8.572 ms) : 0, 8572
Flare Poller [baseline] (3.478 ms) : 0, 3478
Flare Poller [candidate] (3.442 ms) : 0, 3442
section profiling
crashtracking [baseline] (1.24 ms) : 0, 1240
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (689.118 ms) : 0, 689118
BytebuddyAgent [candidate] (681.822 ms) : 0, 681822
AgentMeter [baseline] (8.743 ms) : 0, 8743
AgentMeter [candidate] (8.618 ms) : 0, 8618
GlobalTracer [baseline] (217.588 ms) : 0, 217588
GlobalTracer [candidate] (215.717 ms) : 0, 215717
AppSec [baseline] (33.092 ms) : 0, 33092
AppSec [candidate] (32.614 ms) : 0, 32614
Debugger [baseline] (67.907 ms) : 0, 67907
Debugger [candidate] (67.3 ms) : 0, 67300
Remote Config [baseline] (636.884 µs) : 0, 637
Remote Config [candidate] (626.6 µs) : 0, 627
Telemetry [baseline] (9.123 ms) : 0, 9123
Telemetry [candidate] (9.051 ms) : 0, 9051
Flare Poller [baseline] (3.833 ms) : 0, 3833
Flare Poller [candidate] (3.764 ms) : 0, 3764
ProfilingAgent [baseline] (100.023 ms) : 0, 100023
ProfilingAgent [candidate] (99.541 ms) : 0, 99541
Profiling [baseline] (100.608 ms) : 0, 100608
Profiling [candidate] (100.125 ms) : 0, 100125
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section baseline
no_agent (18.034 ms) : 17848, 18221
. : milestone, 18034,
appsec (18.734 ms) : 18541, 18926
. : milestone, 18734,
code_origins (17.481 ms) : 17311, 17651
. : milestone, 17481,
iast (17.96 ms) : 17782, 18139
. : milestone, 17960,
profiling (18.42 ms) : 18238, 18601
. : milestone, 18420,
tracing (17.741 ms) : 17564, 17918
. : milestone, 17741,
section candidate
no_agent (19.467 ms) : 19268, 19665
. : milestone, 19467,
appsec (19.565 ms) : 19367, 19764
. : milestone, 19565,
code_origins (18.126 ms) : 17939, 18313
. : milestone, 18126,
iast (17.671 ms) : 17494, 17849
. : milestone, 17671,
profiling (18.496 ms) : 18312, 18680
. : milestone, 18496,
tracing (17.652 ms) : 17479, 17825
. : milestone, 17652,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section baseline
no_agent (1.194 ms) : 1182, 1205
. : milestone, 1194,
iast (3.238 ms) : 3191, 3285
. : milestone, 3238,
iast_FULL (5.779 ms) : 5721, 5837
. : milestone, 5779,
iast_GLOBAL (3.567 ms) : 3513, 3620
. : milestone, 3567,
profiling (2.139 ms) : 2118, 2159
. : milestone, 2139,
tracing (1.843 ms) : 1827, 1860
. : milestone, 1843,
section candidate
no_agent (1.273 ms) : 1260, 1287
. : milestone, 1273,
iast (3.245 ms) : 3201, 3289
. : milestone, 3245,
iast_FULL (5.978 ms) : 5918, 6038
. : milestone, 5978,
iast_GLOBAL (3.664 ms) : 3596, 3733
. : milestone, 3664,
profiling (1.99 ms) : 1972, 2008
. : milestone, 1990,
tracing (1.861 ms) : 1845, 1878
. : milestone, 1861,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1488
. : milestone, 1477,
appsec (2.501 ms) : 2447, 2555
. : milestone, 2501,
iast (2.256 ms) : 2187, 2325
. : milestone, 2256,
iast_GLOBAL (2.31 ms) : 2240, 2380
. : milestone, 2310,
profiling (2.077 ms) : 2023, 2131
. : milestone, 2077,
tracing (2.07 ms) : 2017, 2124
. : milestone, 2070,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.818 ms) : 3597, 4040
. : milestone, 3818,
iast (2.259 ms) : 2189, 2328
. : milestone, 2259,
iast_GLOBAL (2.287 ms) : 2218, 2357
. : milestone, 2287,
profiling (2.085 ms) : 2030, 2139
. : milestone, 2085,
tracing (2.069 ms) : 2016, 2122
. : milestone, 2069,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.60.0-SNAPSHOT~5860d2e5dc, baseline=1.60.0-SNAPSHOT~16f36474a2
dateFormat X
axisFormat %s
section baseline
no_agent (14.723 s) : 14723000, 14723000
. : milestone, 14723000,
appsec (14.903 s) : 14903000, 14903000
. : milestone, 14903000,
iast (18.15 s) : 18150000, 18150000
. : milestone, 18150000,
iast_GLOBAL (17.782 s) : 17782000, 17782000
. : milestone, 17782000,
profiling (15.191 s) : 15191000, 15191000
. : milestone, 15191000,
tracing (14.619 s) : 14619000, 14619000
. : milestone, 14619000,
section candidate
no_agent (14.97 s) : 14970000, 14970000
. : milestone, 14970000,
appsec (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
iast (18.567 s) : 18567000, 18567000
. : milestone, 18567000,
iast_GLOBAL (17.703 s) : 17703000, 17703000
. : milestone, 17703000,
profiling (14.931 s) : 14931000, 14931000
. : milestone, 14931000,
tracing (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
This PR reduces verbosity of StatsD connection error.
It keeps full details / stack trace in debug logs.
Motivation
Using read-only file system, users get the following log message which is quite verbose and scary:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.