Open
Conversation
* we don't ship the programs (zstd.exe), so there is no need to build them * we're fine with additionally shipping include/zdict.h and lib/cmake/ * we also ship the library PDBs
As of zstd 1.5.4 the patch no longer applies; we reduce its context as a workaround.
shivammathur
force-pushed
the
master
branch
2 times, most recently
from
52b22a5 to
8fa9b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for more details.
TL;DR: the first commit fixes the artifacts, so that the package can be shipped as built. The other two commits fix incompatibilities with newer zstd versions, and as such are an alternative to #28.
PS: test builds at https://github.com/winlibs/winlib-builder/actions/workflows/libzstd.yml.