update patch for libzstd version 1.5.6#28
Open
macintoshplus wants to merge 1 commit intowinlibs:masterfrom
Open
update patch for libzstd version 1.5.6#28macintoshplus wants to merge 1 commit intowinlibs:masterfrom
macintoshplus wants to merge 1 commit intowinlibs:masterfrom
Conversation
Member
|
Thanks for the PR! It's overdue that we ship updated zstd. I think we can do without having to drop support for somewhat older zstd versions, though. The fix for the broken resource compilation in zstd 1.5.6 (facebook/zstd#3999) could be moved to the builder like demonstrated in that ticket (works for 1.4.8 and 1.5.6 and likely other versions too). To be able to cleanly apply the existing patch, we could modify it to use only two lines of context; that seems to be sufficient in this case. And in the long run we should use pkg-config for building PHP on Windows; that would allow to migrate away from any particular naming convention, so we have to apply fewer patches. |
Member
|
See #33 for an alternative. |
52b22a5 to
8fa9b53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To build the libzstd, a patch must be applied to change the output filename.
With v1.5.6, the patch does not work due to changes in the target file and another bug.
This patch is proposed to replace the actual patch. I have been building version 1.5.6 for ARM64.