refactor: modify the return type of the process function using tl_expected #24
+18
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Related Links
TIER IV INTERNAL LINK
Description
This pull request refactors the
BaseProcessorclass to improve error handling by introducing a new result type for image processing, and updates dependencies and build configuration accordingly. The main improvements are focused on making the processing outcome explicit and easier to handle, as well as ensuring the necessary dependencies are declared.Error handling and API improvements:
result_ttype alias inBaseProcessor, which usestl::expected<Image, std::string>to represent either a successfully processed image or an error message. (processor.hpp)processmethod to returnresult_tinstead ofvoid, providing clear feedback on processing success or failure with appropriate error messages. (processor.hpp) [1] [2]Dependency and build configuration:
tl_expectedas a dependency inpackage.xmland included its header inprocessor.hppto support the new result type. (package.xml,processor.hpp) [1] [2]CMakeLists.txt)Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks