[PR] apply the background-color also on tab-view#540
Open
fls-indinf wants to merge 7 commits intosibvisions:masterfrom
Open
[PR] apply the background-color also on tab-view#540fls-indinf wants to merge 7 commits intosibvisions:masterfrom
fls-indinf wants to merge 7 commits intosibvisions:masterfrom
Conversation
Author
|
@mhandsteiner Is there anything left to fix with this, as you pushed the commit in 3d182e9 |
Member
|
We'll check your solution but have an idea for a different solution. We'll keep you up-to-date. |
Member
|
We pushed a different solution. Just try it! |
Setting the background-color on the TabsetPanel had no effect on the tabs.
```java
UITabsetPanel tp = new UITabsetPanel();
tp.setBackground(UIColor.red);
```
badf87f to
1e6081b
Compare
Setting the background-color on the TabsetPanel had no effect on the tabs.
```java
UITabsetPanel tp = new UITabsetPanel();
tp.setBackground(UIColor.red);
```
…ndcolor' into feature/tabsetpanel-backgroundcolor
Author
What exactly do you mean? |
Member
Current master branch contains a solution for the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting the background-color on the TabsetPanel had no effect on the tab-view part of the UITabsetPanel.
I am having something like that in Java:
With the fix, the result looks more as I'd expect it to behave:

Whether some sort of additional styling to make that a bit more appealing, is still open for discussion.
That's why I set this PR as "allow edits by maintainers".
Have a nice day! 🌄