Skip to content

[PR] apply the background-color also on tab-view#540

Open
fls-indinf wants to merge 7 commits intosibvisions:masterfrom
fls-indinf:feature/tabsetpanel-backgroundcolor
Open

[PR] apply the background-color also on tab-view#540
fls-indinf wants to merge 7 commits intosibvisions:masterfrom
fls-indinf:feature/tabsetpanel-backgroundcolor

Conversation

@fls-indinf
Copy link

Setting the background-color on the TabsetPanel had no effect on the tab-view part of the UITabsetPanel.

I am having something like that in Java:

  public SimpleWorkScreen(IWorkScreenApplication pApplication, AbstractConnection pConnection) throws Throwable {
    super(pApplication, pConnection, null);

    setLayout(new UIBorderLayout());

    UITabsetPanel tp = new UITabsetPanel();
    tp.setBackground(UIColor.red);
    add(tp, IBorderLayout.CENTER);

    UIPanel p = new UIPanel();
    p.setBackground(UIColor.white);
    tp.add(p, "red button on red tab");

    UIButton b = new UIButton("this button is red");
    b.setBackground(UIColor.red);
    p.add(b);

    tp.add(new UIPanel(), "another, unselected tab on the red tabsetpanel");
  }

With the fix, the result looks more as I'd expect it to behave:
grafik

Whether some sort of additional styling to make that a bit more appealing, is still open for discussion.
That's why I set this PR as "allow edits by maintainers".

Have a nice day! 🌄

@fls-indinf
Copy link
Author

@mhandsteiner Is there anything left to fix with this, as you pushed the commit in 3d182e9

@rjahn
Copy link
Member

rjahn commented Jul 8, 2025

We'll check your solution but have an idea for a different solution. We'll keep you up-to-date.

@rjahn
Copy link
Member

rjahn commented Jul 21, 2025

We pushed a different solution. Just try it!

Setting the background-color on the TabsetPanel had no effect on the tabs.
```java
    UITabsetPanel tp = new UITabsetPanel();
    tp.setBackground(UIColor.red);
```
@fls-indinf fls-indinf force-pushed the feature/tabsetpanel-backgroundcolor branch from badf87f to 1e6081b Compare July 21, 2025 11:36
Setting the background-color on the TabsetPanel had no effect on the tabs.
```java
    UITabsetPanel tp = new UITabsetPanel();
    tp.setBackground(UIColor.red);
```
…ndcolor' into feature/tabsetpanel-backgroundcolor
@fls-indinf
Copy link
Author

We pushed a different solution. Just try it!

What exactly do you mean?

@rjahn
Copy link
Member

rjahn commented Jul 23, 2025

We pushed a different solution. Just try it!

What exactly do you mean?

Current master branch contains a solution for the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants