setting the background color of UIButton has no effect

[fls-indinf]

Hi JVx-Engineering Team!

We recently noticed, that applying a background-color on a UIButton in Java has no effect in React.

In Java Swing it does look like that:

In React sadly not:

public class SimpleWorkScreen extends DataSourceWorkScreen {
  private static final long serialVersionUID = 1L;

  public SimpleWorkScreen(IWorkScreenApplication pApplication, AbstractConnection pConnection) throws Throwable {
    super(pApplication, pConnection, null);

    UIButton b = new UIButton("this button is red");
    b.setBackground(UIColor.red);
    add(b);

  }

}

It does seem to at least transfer the property to the React-Side

Thank you for your awesome support 👍

Have a nice day,
Florian

[rjahn]

Works in our environment:

swing UI:

react UI:

The orange color is right because it's the default background color of our style. There's also no problem with UIColor.red:

[fls-indinf]

Thank you for the quick response.
You are definitely right, I am sorry for that. It seems like I caught a unclean branch to check that issue.

It seems like a (pretty rare) quick-fix to be able to set the background-color of the UITabsetPanel.tsx seemed to have caused the issue:

I noticed the TabsetPanelImpl.tsx sets the background-color of the "tab"-section (--tab-navbar-background) from the property "props.compStyle.backgroundColor" instead of the usually parsed "props.compStyle.background".

Should I recreate a separate bugreport for the Tabset-Issue or is it not intended to change that color?

[rjahn]

Feel free to send us a PR and we'll check it.

[rjahn]

In our codebase, the code is:

colorProperties.background = setColor;

This is correct.

In our codebase, there's no:

props.compStyle.backgroundColor

[fls-indinf]

Hi,
I added #540 fixing the initial issue, we tried to fix by modifying the useComponentStyle.tsx
This is now a more condensed and less intrusive solution, which we initially had as workaround.

[rjahn]

We changed coloring a little bit in current master. Please try the current implementation.

[fls-indinf]

I tried to quickly update to the latest git (a completely fresh copy).
Currently it does not apply the red color to my button:

It seems like useButtonStyling reads compStyle?.background and useComponentStyle assigns since 3d182e9 to colorProperties.backgroundColor (just a wild guess).

After making useComponentStyle.tsx assign the color now to background, it does work again.