-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
DOC: update Series() docstring about copy behaviour #63341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jorisvandenbossche
wants to merge
2
commits into
pandas-dev:main
Choose a base branch
from
jorisvandenbossche:cow-doc-series-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -265,8 +265,13 @@ class Series(base.IndexOpsMixin, NDFrame): # type: ignore[misc] | |||||
| See the :ref:`user guide <basics.dtypes>` for more usages. | ||||||
| name : Hashable, default None | ||||||
| The name to give to the Series. | ||||||
| copy : bool, default False | ||||||
| Copy input data. Only affects Series or 1d ndarray input. See examples. | ||||||
| copy : bool, default None | ||||||
| Whether to copy input data. Only affects array or Series/Index input, | ||||||
| because for other input (e.g. a list) a new array is created anyway. | ||||||
| By default, will copy if the input data is a numpy or pandas array. | ||||||
| For Series/Index input, a shallow copy of the data is made by default. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's not quite clear to me what happens if you set it to False in the Series/Index case. |
||||||
| Set to False to avoid copying array input, at your own risk (if you | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: no comma.
Suggested change
|
||||||
| know the input data won't be modified elsewhere). | ||||||
|
|
||||||
| See Also | ||||||
| -------- | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to #63144, the question is what to put here in the docstring ..
copy=Noneis closest to what is in the signature, but is not really meaningful by itself. Of course, the behaviour also depends on the intput, so writing that it defaults to either True or False will also be misleading for some cases.(eg the current
default Falsein the docstring above is not correct for array input)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with
Nonehere, I think the behavior is too complex to give a meaningful description in the space allowed.