Skip to content

Conversation

@jorisvandenbossche
Copy link
Member

No description provided.

The name to give to the Series.
copy : bool, default False
Copy input data. Only affects Series or 1d ndarray input. See examples.
copy : bool, default None
Copy link
Member Author

@jorisvandenbossche jorisvandenbossche Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to #63144, the question is what to put here in the docstring ..

copy=None is closest to what is in the signature, but is not really meaningful by itself. Of course, the behaviour also depends on the intput, so writing that it defaults to either True or False will also be misleading for some cases.
(eg the current default False in the docstring above is not correct for array input)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with None here, I think the behavior is too complex to give a meaningful description in the space allowed.

@jorisvandenbossche jorisvandenbossche marked this pull request as ready for review December 12, 2025 09:58
Whether to copy input data. Only affects array or Series/Index input,
because for other input (e.g. a list) a new array is created anyway.
By default, will copy if the input data is a numpy or pandas array.
For Series/Index input, a shallow copy of the data is made by default.
Copy link
Member

@rhshadrach rhshadrach Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite clear to me what happens if you set it to False in the Series/Index case.

because for other input (e.g. a list) a new array is created anyway.
By default, will copy if the input data is a numpy or pandas array.
For Series/Index input, a shallow copy of the data is made by default.
Set to False to avoid copying array input, at your own risk (if you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no comma.

Suggested change
Set to False to avoid copying array input, at your own risk (if you
Set to False to avoid copying array input at your own risk (if you

The name to give to the Series.
copy : bool, default False
Copy input data. Only affects Series or 1d ndarray input. See examples.
copy : bool, default None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with None here, I think the behavior is too complex to give a meaningful description in the space allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants