Skip to content

Pass scope to get_sorted_metrics#4150

Merged
xrmx merged 3 commits intoopen-telemetry:mainfrom
anuraaga:sorted-metrics-scope
Feb 4, 2026
Merged

Pass scope to get_sorted_metrics#4150
xrmx merged 3 commits intoopen-telemetry:mainfrom
anuraaga:sorted-metrics-scope

Conversation

@anuraaga
Copy link
Contributor

Description

Passes scope when getting sorted metrics in tests for instrumentation that fail in open-telemetry/opentelemetry-python#4880

/cc @xrmx

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 4, 2026
@xrmx xrmx enabled auto-merge (squash) February 4, 2026 16:16
@xrmx xrmx merged commit 6a1a74f into open-telemetry:main Feb 4, 2026
663 checks passed
wikaaaaa pushed a commit to wikaaaaa/opentelemetry-python-contrib that referenced this pull request Feb 5, 2026
* Pass scope to get_sorted_metrics

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants