Skip to content

Add scope to metric assertions in more tests#4165

Merged
xrmx merged 4 commits intoopen-telemetry:mainfrom
anuraaga:scope-more
Feb 10, 2026
Merged

Add scope to metric assertions in more tests#4165
xrmx merged 4 commits intoopen-telemetry:mainfrom
anuraaga:scope-more

Conversation

@anuraaga
Copy link
Contributor

@anuraaga anuraaga commented Feb 5, 2026

Description

Passes scope when getting sorted metrics in tests for instrumentation that fail in open-telemetry/opentelemetry-python#4880

Follow up to #4150 with some more spots I missed

/cc @xrmx

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 10, 2026
@xrmx xrmx moved this to Approved PRs in @xrmx's Python PR digest Feb 10, 2026
@xrmx xrmx enabled auto-merge (squash) February 10, 2026 14:29
@xrmx xrmx merged commit 16f7be0 into open-telemetry:main Feb 10, 2026
663 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in @xrmx's Python PR digest Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants