Skip to content

feat: add support for aiobotocore instrumentation #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
herin049 wants to merge 5 commits into
base: main
Choose a base branch
from
+844 −134
Open

feat: add support for aiobotocore instrumentation #4049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d634eac
initial implementation for aiobotocore instrumentation
herin049 Dec 23, 2025
f625693
fix failing tests
herin049 Dec 23, 2025
9f0efae
add basic set of tests for aiobotocore instrumentation
herin049 Dec 24, 2025
72d3e9e
fix lint error
herin049 Dec 24, 2025
f1c168b
update CHANGELOG.md
herin049 Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
([#3681](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3681))
- `opentelemetry-instrumentation-flask`: Fix exemplars generation for `http.server.request.duration` and `http.server.duration` metrics
([#3912](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3912))
- `opentelemetry-instrumentation-botocore`: Add support for instrumenting `aiobotocore`
([#4049](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4049))

### Added

Expand Down
1 change: 1 addition & 0 deletions instrumentation/opentelemetry-instrumentation-botocore/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ instruments = [

[project.entry-points.opentelemetry_instrumentor]
botocore = "opentelemetry.instrumentation.botocore:BotocoreInstrumentor"
aiobotocore = "opentelemetry.instrumentation.botocore:AiobotocoreInstrumentor"
Copy link
Contributor

@xrmx xrmx Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code above should be updated to something like the following:

[project.optional-dependencies]
instruments = []
instruments-any = [
  "botocore ~= 1.0",
  "aiobotoore ~= 2.0"
]

Copy link
Contributor Author

@herin049 herin049 Jan 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure I'm understanding what you're saying here. Are you suggesting we just have a single opentelemetry_instrumentor entrypoint pointing to the BotocoreInstrumentor class, and only apply the aiobotocore patches if it is installed? I did initially consider this, but I did also want to potentially give users the ability to selectively instrument only aiobotocore or botocore. But in practice, I don't see a reason why you would ever want to do this. WDYT?


[project.urls]
Homepage = "https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation/opentelemetry-instrumentation-botocore"
Expand Down
Loading