feat: add support for aiobotocore instrumentation #4049
Conversation
herin049
changed the title
|
@lukeina2z @yiyuan-he wdyt? |
|
|
||
|
|
||
| _instruments = ("botocore ~= 1.0",) | ||
| _aiobotocore_instruments = ("aiobotocore ~= 2.0",) |
There was a problem hiding this comment.
This should looks something like the following so that opentelemetry-bootstrap will work with that.
_instruments_botocore = "botocore ~= 1.0"
_instruments_aiobotocore = "aiobotocore ~= 2.0"
_instruments = ()
_instruments_any = (_instruments_botocore, _instruments_aiobotocore)
|
|
||
| [project.entry-points.opentelemetry_instrumentor] | ||
| botocore = "opentelemetry.instrumentation.botocore:BotocoreInstrumentor" | ||
| aiobotocore = "opentelemetry.instrumentation.botocore:AiobotocoreInstrumentor" |
There was a problem hiding this comment.
Code above should be updated to something like the following:
[project.optional-dependencies]
instruments = []
instruments-any = [
"botocore ~= 1.0",
"aiobotoore ~= 2.0"
]
There was a problem hiding this comment.
Just want to make sure I'm understanding what you're saying here. Are you suggesting we just have a single opentelemetry_instrumentor entrypoint pointing to the BotocoreInstrumentor class, and only apply the aiobotocore patches if it is installed? I did initially consider this, but I did also want to potentially give users the ability to selectively instrument only aiobotocore or botocore. But in practice, I don't see a reason why you would ever want to do this. WDYT?
| except Exception as ex: # pylint: disable=broad-except | ||
| _logger.error("Error when loading extension: %s", ex) | ||
| return _AwsSdkExtension(call_context) | ||
| _AIOBOTOCORE_EXTENSIONS = { |
There was a problem hiding this comment.
Any specific reason why bedrock is not there?
2 participants
Description
Adds support for aiobotocore instrumentation, following the implementation approach outlined in issue #4048.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests have been added.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.