Skip to content

XMLTools: use try-with-resources statement #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
melissalinkert merged 1 commit into from
Feb 5, 2026
Merged

XMLTools: use try-with-resources statement #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/main/java/loci/common/xml/XMLTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,12 +189,9 @@ public static Document createDocument() {
public static Document parseDOM(File file)
throws ParserConfigurationException, SAXException, IOException
{
InputStream is = new FileInputStream(file);
try {
try (InputStream is = new FileInputStream(file)) {
Document doc = parseDOM(is);
return doc;
} finally {
is.close();
}
}

Expand All @@ -211,12 +208,9 @@ public static Document parseDOM(String xml)
throws ParserConfigurationException, SAXException, IOException
{
byte[] bytes = xml.getBytes(Constants.ENCODING);
InputStream is = new ByteArrayInputStream(bytes);
try {
try (InputStream is = new ByteArrayInputStream(bytes)) {
Document doc = parseDOM(is);
return doc;
} finally {
is.close();
}
}

Expand Down
Loading