XMLTools: use try-with-resources statement#111
Merged
melissalinkert merged 1 commit intoome:masterfrom Feb 5, 2026
Merged
Conversation
melissalinkert
approved these changes
Feb 4, 2026
Member
melissalinkert
left a comment
melissalinkert
left a comment
There was a problem hiding this comment.
Makes sense, just waiting on a passing nightly build to be safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the APIs consumed in ome/bioformats#4408, I realised these implementations still use old
try/finallyblock. This updates these to use try-with-resources statements introduced since Java 8.Functionally there should be no change to the usage or tests