[ADD] estate: add real estate module (framework 101 tutorial) #1077

robal-odoo · 2025-12-16T12:27:08Z

No description provided.

robodoo · 2025-12-16T12:27:10Z

ushyme

Good work so far. I just have a few suggestions.

ushyme · 2025-12-17T12:32:13Z

estate/__manifest__.py

+    'name': 'Real Estate',
+    'description': 'Real Estate Advertising',
+    # 'version': '1.0',
+    'author': 'robal',


Suggested change

'author': 'robal',

'author': 'Odoo S.A.',

As an Odoo employee, you are creating this module in the name of Odoo

ushyme · 2025-12-17T12:43:00Z

estate/models/estate_property.py

+    name = fields.Char(string="Title", required=True)
+    description = fields.Text()
+    postcode = fields.Char()
+    date_availability = fields.Date(string="Available From", default=fields.Date.today() + relativedelta(months=3), copy=False)


Suggested change

date_availability = fields.Date(string="Available From", default=fields.Date.today() + relativedelta(months=3), copy=False)

date_availability = fields.Date(string="Available From", default=lambda self: fields.Date.context_today(self) + relativedelta(months=3), copy=False)

date_availability's default was calculated only once at server launch. Wrapping it in a lambda fixes this by computing it dynamically for each new record. I also used fields.Date.context_today(self) for timezone correctness.

ushyme · 2025-12-17T14:29:26Z

estate/models/estate_property.py

+            if record.state == "sold":
+                error_msg = "This property has already been sold."
+                raise UserError(error_msg)


Suggested change

if record.state == "sold":

error_msg = "This property has already been sold."

raise UserError(error_msg)

if record.state == "sold":

continue

In the action_ methods, it's slightly more user-friendly to silently ignore a button click if the record is already in the target state, rather than raising an error.

ushyme · 2025-12-17T14:32:21Z

estate/models/estate_property.py

+                raise UserError(error_msg)
+
+            if record.state == "cancelled":
+                error_msg = "Cancelled properties cannot be sold."


Suggested change

error_msg = "Cancelled properties cannot be sold."

error_msg = record.env._("Cancelled properties cannot be sold.")

User-facing strings in errors and constraints must be wrapped in record.env._() to be translatable.

Is there a practical difference between using record.env._() and using _() imported with from odoo import _ or the one from self.env._() ?

ushyme · 2025-12-17T15:22:38Z

estate/models/estate_property_offer.py

+def _get_reference_date(offer: EstatePropertyOffer) -> date:
+    return fields.Date.today() if not offer.create_date else offer.create_date.date()


I don't know if this function is really helpful here. I think the code would overall be more readable if this logic was inlined directly in the compute/inverse method.

Should I use context_today like in the other model ?

ushyme · 2025-12-19T10:12:25Z

estate/models/estate_property.py

+        for record in self:
+            # Selling price is zero when no offer has been accepted
+            if not float_is_zero(record.selling_price, precision_digits=2) and float_compare(record.selling_price, 0.9 * record.expected_price, precision_digits=2) < 0:
+                raise ValidationError(_("A property's selling price cannot be lower that 90 percent of its expected price."))


Suggested change

raise ValidationError(_("A property's selling price cannot be lower that 90 percent of its expected price."))

raise ValidationError(_("A property's selling price cannot be lower than 90 percent of its expected price."))

small typo

ushyme · 2025-12-19T10:22:41Z

estate/models/estate_property.py

+
+    # Methods that trigger on changes
+    @api.onchange("garden")
+    def _compute_garden_defaults(self) -> None:


Suggested change

def _compute_garden_defaults(self) -> None:

def _onchange_garden_defaults(self) -> None:

This is an onchange, not a compute. Should be named _onchange_garden_defaults or _onchange_garden.

ushyme · 2025-12-19T10:24:06Z

estate_account/models/estate_property.py

+                    Command.create({"name": percent_description, "quantity": 1, "price_unit": 0.06 * record.selling_price}),
+                    Command.create({"name": admin_fee_description, "quantity": 1, "price_unit": 100.0}),
+                ],
+                }


Suggested change

}

}

ushyme · 2025-12-19T10:24:54Z

estate/__manifest__.py

+{
+    "name": "Real Estate",
+    "description": "Real Estate Advertising",
+    "author": "robal",


Suggested change

"author": "robal",

"author": "Odoo S.A.",

As an employee, you work in the name of Odoo.

ushyme · 2025-12-19T10:28:59Z

.gitignore

+
+# VScode
+.vscode/


Suggested change

# VScode

.vscode/

This is personal configuration that shouldn't be pushed to the general codebase.

Framework 101 tutorial - add estate module - add estate_account module for integration with invoicing

robal-odoo force-pushed the 19.0-estate-tutorial-robal branch from 924f90b to 0af92ad Compare December 16, 2025 12:59

robal-odoo changed the title ~~Estate tutorial (robal)~~ [ADD] estate: add real estate module (framework 101 tutorial) Dec 16, 2025

robal-odoo force-pushed the 19.0-estate-tutorial-robal branch from cab625c to d8993d0 Compare December 16, 2025 16:12

robal-odoo marked this pull request as ready for review December 19, 2025 08:21

ushyme reviewed Dec 19, 2025

View reviewed changes

robal-odoo force-pushed the 19.0-estate-tutorial-robal branch from 2fb7576 to 9dd3005 Compare December 19, 2025 12:44

[ADD] estate: add new real estate module

6b2e660

Framework 101 tutorial - add estate module - add estate_account module for integration with invoicing

robal-odoo force-pushed the 19.0-estate-tutorial-robal branch from 440b49e to 6b2e660 Compare December 19, 2025 14:12

	date_availability = fields.Date(string="Available From", default=fields.Date.today() + relativedelta(months=3), copy=False)
	date_availability = fields.Date(string="Available From", default=lambda self: fields.Date.context_today(self) + relativedelta(months=3), copy=False)

	error_msg = "Cancelled properties cannot be sold."
	error_msg = record.env._("Cancelled properties cannot be sold.")

		def _get_reference_date(offer: EstatePropertyOffer) -> date:
		return fields.Date.today() if not offer.create_date else offer.create_date.date()

	raise ValidationError(_("A property's selling price cannot be lower that 90 percent of its expected price."))
	raise ValidationError(_("A property's selling price cannot be lower than 90 percent of its expected price."))

	def _compute_garden_defaults(self) -> None:
	def _onchange_garden_defaults(self) -> None:

[ADD] estate: add real estate module (framework 101 tutorial) #1077

Are you sure you want to change the base?

[ADD] estate: add real estate module (framework 101 tutorial) #1077

Uh oh!

Conversation

robal-odoo commented Dec 16, 2025

Uh oh!

robodoo commented Dec 16, 2025

Uh oh!

ushyme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robal-odoo Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

robal-odoo Dec 19, 2025 •

edited

Loading