[FIX] estate: modernize usage of translation "_"

- It's recommended to call the translate "_" method on the environment.
- The global "_" has some issues and might become deprecated at some point in the future.

Author: robal-odoo

estate/models/estate_property.py

@@ -1,5 +1,5 @@
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models, _
+from odoo import api, fields, models
 from odoo.exceptions import UserError, ValidationError
 from odoo.tools.float_utils import float_compare, float_is_zero
 
@@ -69,7 +69,7 @@ def _onchange_garden_defaults(self) -> None:
     @api.ondelete(at_uninstall=False)
     def _unlink_except_new_or_cancelled(self) -> None:
         if any(record.state not in {"new", "cancelled"} for record in self):
-            raise UserError(_("Cannot delete properties unless they are new or cancelled."))
+            raise UserError(self.env._("Cannot delete properties unless they are new or cancelled."))
 
     # Public methods
     def action_set_sold(self) -> bool:
@@ -78,7 +78,7 @@ def action_set_sold(self) -> bool:
                 continue
 
             if record.state == "cancelled":
-                raise UserError(_("Cancelled properties cannot be sold."))
+                raise UserError(record.env._("Cancelled properties cannot be sold."))
 
             record.state = "sold"
         return True
@@ -89,7 +89,7 @@ def action_set_cancelled(self) -> bool:
                 continue
 
             if record.state == "sold":
-                raise UserError(_("Sold properties cannot be cancelled."))
+                raise UserError(record.env._("Sold properties cannot be cancelled."))
 
             record.state = "cancelled"
         return True
@@ -110,4 +110,4 @@ def _restrict_selling_price(self) -> None:
         for record in self:
             # Selling price is zero when no offer has been accepted
             if not float_is_zero(record.selling_price, precision_digits=2) and float_compare(record.selling_price, 0.9 * record.expected_price, precision_digits=2) < 0:
-                raise ValidationError(_("A property's selling price cannot be lower than 90 percent of its expected price."))
+                raise ValidationError(record.env._("A property's selling price cannot be lower than 90 percent of its expected price."))

estate/models/estate_property_offer.py

@@ -1,7 +1,7 @@
 from datetime import date
 
 from dateutil.relativedelta import relativedelta
-from odoo import api, fields, models, _
+from odoo import api, fields, models
 from odoo.exceptions import UserError
 from odoo.tools.float_utils import float_compare
 
@@ -44,7 +44,7 @@ def create(self, vals):
             estate_property = self.env["estate.property"].browse(val["property_id"])
             best_price = estate_property.best_price or 0.0
             if float_compare(val["price"], best_price, precision_digits=2) < 0:
-                raise UserError(_("A new offer must match or exceed the price of the current best offer."))
+                raise UserError(self.env._("A new offer must match or exceed the price of the current best offer."))
             estate_property.state = "offer_received"
         return super().create(vals)
 
@@ -53,7 +53,7 @@ def action_accept(self) -> bool:
         # TODO double check validation
         for record in self:
             if record.property_id.offer_ids.filtered(lambda r: r.status == "accepted"):
-                raise UserError(_("Cannot accept this offer because another offer has already been accepted for the property."))
+                raise UserError(record.env._("Cannot accept this offer because another offer has already been accepted for the property."))
 
             record.status = "accepted"
             record.property_id.selling_price = record.price