[ADD] Estate Module (Python Framework Training)

[OmarKhalil2001]

[ADD] Implementation for Estate Module of Python Framework

Description:

This Pull Request introduces the Estate Module, which houses the new Estate FelBeit application. This application is designed to provide real estate agents with a centralized system for managing property listings, tracking the sales lifecycle, and handling the relationship between sellers and buyers.

Key Features:

1. Seller Tracking: Associates each property with a seller for streamlined management.
2. Buyer Tracking: Records potential buyers and formally links the successful buyer to the property upon closing.
3. Property Lifecycle Tracking: Provides a state-management system to monitor property stages from initial listing through offer negotiations to the final sale.
4. Offer Management: Enables agents to record offers, track their status, and perform actions to either accept or refuse them.
5. Spatial Calculations: Includes a precision tool to calculate indoor and outdoor areas separately, ensuring accurate property data.

[robodoo]

[barracudapps]

Some comments here and there. Can you also please review your PR title and description following our guidelines (https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html)?
A clear commit message is really important to describe what you did and why you did it.

[barracudapps]

Thanks for the feature. Here are some comments.

Avoid as much redundancy as possible, ease the searching and respect our naming conventions.
Let's take buildings_model.py as an example. The file is in the models folder of the estate module a better naming would have been building.py (or maybe estate_building.py as it allow a quick search on the module name and building.py might exist in many modules with different meanings).
Moreover, as it is a model the name should not be plural. Indeed, this is the template to create one building (multiple times but it's still 1 item).
Last thing here: please follow the instructions as if the task (tutorial) was written by a PO). You can of course challenge everything but I would've gone with a property instead of a building.

Also, can you please change the PR message and tell a bit more about what the added code is doing and why you added these lines?

[barracudapps]

Very good for the PR message! 👍
Small comments and nits for the code but you're on tracks!

[barracudapps]

Good job on your refactoring but still some small consistency issues like here (and the file names)

Suggested change

	_name = "estate.buildings"
	_name = 'estate.building'

[barracudapps]

Still some nits

[barracudapps]

Nit here

Suggested change

	from odoo import models, fields, api
	from odoo.exceptions import UserError
	from datetime import timedelta
	from odoo.tools.float_utils import float_compare
	from datetime import timedelta
	from odoo import models, fields, api
	from odoo.exceptions import UserError
	from odoo.tools.float_utils import float_compare

[barracudapps]

Same as for buildings, make it consistent

Suggested change

	_name = "estate.offers"
	_name = "estate.offer"

[barracudapps]

IMHO this is more readable

Suggested change

	if record.status != "accepted" and record.building_id.state not in [
	"sold",
	"canceled",
	]:
	if record.status != 'accepted' and record.building_id.state not in ['sold', 'canceled']:

[barracudapps]

Suggested change

	raise UserError(
	self.env._("Cannot accept offers for sold or canceled buildings.")
	)
	raise UserError(self.env._("Cannot accept offers for sold or canceled buildings."))

[barracudapps]

As we know float_compare returns either 1, 0 or -1 you can save some characters to keep the condition on a single line

Suggested change

	if (
	float_compare(
	0.9 * record.building_id.value, record.price, precision_digits=2
	)
	== 1
	):
	if float_compare(0.9 * record.building_id.value, record.price, precision_digits=2) > 0: