[CLN] Addressing Clean Code comments for Estate Module. Added newlines to the end of files. Improved the readability of manifest. renamed model classes to follow the pascal casing.

Author: OmarKhalil2001

estate/__manifest__.py

@@ -1,10 +1,14 @@
 {
-    "name": "real estate",
-    "description": "real estate renting management system",
+    "name": "Real Estate",
+    "description": "Real Estate Management System",
     "category": "Tutorials",
     "version": "1.1",
     "application": True,
-    "data": ["security/ir.model.access.csv", "views/views.xml", "views/menus.xml"],
-    "author": "OMKHA",
+    "data": [
+        "security/ir.model.access.csv",
+        "views/views.xml",
+        "views/menus.xml"
+    ],
+    "author": "Odoo S.A.",
     "license": "LGPL-3",
 }

estate/models/building_type_model.py

@@ -1,7 +1,7 @@
 from odoo import models, fields
 
 
-class building_type_model(models.Model):
+class BuildingType(models.Model):
     _name = "estate.building_type"
     _description = "Building Type Model"
 

estate/models/buildings_model.py

@@ -3,7 +3,7 @@
 from datetime import timedelta
 
 
-class buildings_model(models.Model):
+class Building(models.Model):
     _name = "estate.buildings"
     _description = "Buildings Model"
 

estate/models/offers_model.py

@@ -3,7 +3,7 @@
 from datetime import timedelta
 
 
-class offers_model(models.Model):
+class Offer(models.Model):
     _name = "estate.offers"
     _description = "Offers Model"
 

estate/models/tags_model.py

@@ -1,7 +1,7 @@
 from odoo import models, fields
 
 
-class building_tags_model(models.Model):
+class BuildingTag(models.Model):
     _name = "estate.building_tags"
     _description = "Building Tags Model"
 

estate/security/ir.model.access.csv

@@ -2,4 +2,4 @@ id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
 access_first_model,access_first_model,model_estate_buildings,base.group_user,1,1,1,1
 access_building_type_model,access_building_type_model,model_estate_building_type,base.group_user,1,1,1,1
 access_building_tags_model,access_building_tags_model,model_estate_building_tags,base.group_user,1,1,1,1
-access_offers_model,access_offers_model,model_estate_offers,base.group_user,1,1,1,1
+access_offers_model,access_offers_model,model_estate_offers,base.group_user,1,1,1,1

estate/views/menus.xml

@@ -5,4 +5,4 @@
             <menuitem id="test_model_menu_action" action="some_model_action_1"/>
         </menuitem>
     </menuitem>
-</odoo>
+</odoo>

estate/views/views.xml

@@ -68,8 +68,8 @@
                                     <field name="partner_id"/>
                                     <field name="date_deadline"/>
                                     <field name="validity"/>
-                                    <button name="action_accept_offer" type="object" string="" icon="fa-check"/>
-                                    <button name="action_refuse_offer" type="object" string="" icon="fa-times"/>
+                                    <button name="action_accept_offer" type="object" string="Accept" icon="fa-check"/>
+                                    <button name="action_refuse_offer" type="object" string="Refuse" icon="fa-times"/>
                                 </list>
                             </field>
                             <group>
@@ -90,11 +90,10 @@
                 <field name="name"/>
                 <field name="value"/>
                 <separator/>
-                <filter string="Available" name="Available" domain="['|', ('state', '=', 'new' ), ('state', '=', 'offer received')]"/>
+                <filter string="Available" name="Available" domain="[('state', 'in', ['new', 'offer_received'])]"/>
                 <filter string="postcode" name="postcode" context="{'group_by':'post_code'}"/>
             </search>
 
         </field>
     </record>
-    
 </odoo>