Defer customization filtering in EnsureBuilt to allow visitor transformations #9665
+85
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… method suppression Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
microsoft-github-policy-service
bot
added
the
emitter:client:csharp
Copilot
AI
changed the title
[WIP] Fix bug in CreateOrUpdate method parameter merging
Fix IsNameMatch to compare generic type arguments when matching custom methods
Feb 10, 2026
…ansformations Co-authored-by: ArthurMa1978 <20514459+ArthurMa1978@users.noreply.github.com>
Copilot
AI
changed the title
Fix IsNameMatch to compare generic type arguments when matching custom methods
Defer customization filtering in EnsureBuilt to allow visitor transformations
Feb 10, 2026
| /// <summary> | ||
| /// Mutable override for BuildMethods. When set, BuildMethods returns this instead of the constructor-provided methods. | ||
| /// </summary> | ||
| internal MethodProvider[]? MethodsOverride { get; set; } |
Contributor
There was a problem hiding this comment.
@copilot we should come up with another approach that doesn't involve adding this property solely for testing
Contributor
Author
There was a problem hiding this comment.
Removed MethodsOverride from TestTypeProvider and restored it to its original state. The test now uses a local MutableMethodsTypeProvider class private to OutputLibraryVisitorTests.cs instead. Commit: 0c3ba9d
…modifying TestTypeProvider Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
| /// </summary> | ||
| private class MutableMethodsTypeProvider : TypeProvider | ||
| { | ||
| public MethodProvider[] Methods_ { get; set; } = []; |
…ntion Co-authored-by: JoshLove-msft <54595583+JoshLove-msft@users.noreply.github.com>
JoshLove-msft
requested review from
ShivangiReja,
christothes,
jorgerangel-msft,
joseharriaga,
jsquire and
m-nash
as code owners
| // Filtering is deferred to CSharpGen.ExecuteAsync after visitors have had a chance | ||
| // to transform members (e.g., merging parameters). This ensures visitors see the | ||
| // full set of members before customization filtering is applied. | ||
| _methods ??= BuildMethods(); |
Contributor
There was a problem hiding this comment.
do we still need the filtering that is done on the TypeProvider's property's accessors? ie.
Contributor
There was a problem hiding this comment.
Yes, I think so, at least we do if we don't want to update hundreds of tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EnsureBuilt(), butEnsureBuilt()triggersMethodslazy init which applies customization filtering prematurely, removing methods before visitors can transform themEnsureBuilt()to build members without applying customization filtering, deferring it toCSharpGen.ExecuteAsyncafter visitors runMethodIsNotFilteredWhenVisitorChangesSignaturethat verifies a method matching custom code is preserved throughEnsureBuilt()so visitors can transform itMethodsOverridefromTestTypeProviderand replaced with a localMutableMethodsTypeProviderclass private to the test fileMethods_toMethodProvidersfollowing existing convention fromClientCustomizationTests💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.