Skip to content

Conversation

@fujitatomoya
Copy link
Contributor

closes #311

related to ros2/rmw#390 and ros2/rmw#390

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Contributor Author

@pablogs9 can you take a look?

Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
@fujitatomoya
Copy link
Contributor Author

@pablogs9 ros2/rmw#393 has been merged, is this good to go?

@pablogs9
Copy link
Member

pablogs9 commented Mar 5, 2025

CI is ok, so we are good to go.

@fujitatomoya thanks for the contribution!

@pablogs9 pablogs9 merged commit 092bf25 into micro-ROS:rolling Mar 5, 2025
3 checks passed
pablogs9 added a commit that referenced this pull request Mar 5, 2025
@fujitatomoya
Copy link
Contributor Author

@pablogs9 you already reverted this PR from rolling?

@pablogs9
Copy link
Member

pablogs9 commented Mar 6, 2025

Hello @fujitatomoya yes, I have reverted it temporarily because it breaks micro-ROS functionality on our hardware in the loop CI/CD, we are still investigating. As soon as I find what happens, I will restore it and open a PR to fix the problem.

@fujitatomoya
Copy link
Contributor Author

@pablogs9 okay thanks for checking that. please be advised that this must go with ros2/rmw#393 latest rolling fix. otherwise, it breaks build.

@pablogs9
Copy link
Member

pablogs9 commented Mar 7, 2025

Yes, sure, the point is that it works on Linux, but somehow, it is failing to initialize in embedded platforms (ESPIDF and Renesas RA by now), which we are currently investigating.

@fujitatomoya
Copy link
Contributor Author

thanks! let me know if anything i can help on my side.

@pablogs9
Copy link
Member

@fujitatomoya, it was our micro-ROS fork of RCL that failed to validate the enclave as being NULL. Fixed here: micro-ROS/rcl#24

I'm restoring this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants