-
Notifications
You must be signed in to change notification settings - Fork 33
use rmw_enclave_options_xxx APIs instead. #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@pablogs9 can you take a look? |
Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
|
@pablogs9 ros2/rmw#393 has been merged, is this good to go? |
|
CI is ok, so we are good to go. @fujitatomoya thanks for the contribution! |
|
@pablogs9 you already reverted this PR from rolling? |
|
Hello @fujitatomoya yes, I have reverted it temporarily because it breaks micro-ROS functionality on our hardware in the loop CI/CD, we are still investigating. As soon as I find what happens, I will restore it and open a PR to fix the problem. |
|
@pablogs9 okay thanks for checking that. please be advised that this must go with ros2/rmw#393 latest rolling fix. otherwise, it breaks build. |
|
Yes, sure, the point is that it works on Linux, but somehow, it is failing to initialize in embedded platforms (ESPIDF and Renesas RA by now), which we are currently investigating. |
|
thanks! let me know if anything i can help on my side. |
|
@fujitatomoya, it was our micro-ROS fork of RCL that failed to validate the enclave as being NULL. Fixed here: micro-ROS/rcl#24 I'm restoring this PR |
closes #311
related to ros2/rmw#390 and ros2/rmw#390