feat: add /speckit.cleanup command for post-implementation review#1617
Open
dsrednicki wants to merge 3 commits intogithub:mainfrom
Open
feat: add /speckit.cleanup command for post-implementation review#1617dsrednicki wants to merge 3 commits intogithub:mainfrom
dsrednicki wants to merge 3 commits intogithub:mainfrom
Conversation
Add a new cleanup command that runs after implementation to: - Fix small issues immediately (Scout Rule): debug statements, unused imports, dead code, hardcoded localhost URLs - Create follow-up tasks for medium issues: missing error handling, code duplication, incomplete documentation - Generate tech-debt-report.md for large issues: architectural concerns, security vulnerabilities, with options analysis and recommendations The command includes: - Constitution compliance checking - Linter deference for style issues - User confirmation before applying fixes - Critical issue detection (halts on hardcoded credentials) - Idempotent execution (safe to run multiple times) All outputs stay within the feature directory to maintain traceability through the full lifecycle: Spec → Plan → Tasks → Implement → Cleanup
- Add handoff from implement.md to cleanup command - Add cleanup phase (N+1) to tasks-template.md - Update phase dependencies to include cleanup as final gate - Update incremental delivery strategy to include cleanup step - Suggest running cleanup after implementation completes
- Add step 7 for cleanup in quick start guide - Add cleanup to core commands table - Add detailed step 8 in walkthrough section explaining: - Small/medium/large issue handling - Output artifacts (fixes, tasks, tech-debt-report.md) - Critical issue halt behavior
Collaborator
|
For new commands please use the extensions mechanism as described at https://github.com/github/spec-kit/tree/main/extensions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new
/speckit.cleanupcommand that provides a final quality gate after implementation. The command reviews all changes made during implementation and handles issues based on severity:Key Features
Workflow Integration
The cleanup phase completes the spec-driven development lifecycle:
All outputs stay within the feature directory (
/specs/[###-feature-name]/) maintaining full traceability.Changes
templates/commands/cleanup.md- New cleanup command (482 lines)templates/commands/implement.md- Added handoff to cleanup commandtemplates/tasks-template.md- Added cleanup phase (N+1) to task structureREADME.md- Added cleanup to quick start guide and command referenceTest plan