Skip to content

⚡ Avoid unnecessary String construction in CustomClassMapper #1182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lahirumaramba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Avoid unnecessary String construction in CustomClassMapper #1182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/main/java/com/google/firebase/database/utilities/encoding/CustomClassMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,19 +730,21 @@ public T deserialize(Map<String, Object> values, Map<TypeVariable<Class<T>>, Typ
throw new RuntimeException(e);
}
} else {
String message =
"No setter/field for "
+ propertyName
+ " found "
+ "on class "
+ this.clazz.getName();
if (this.properties.containsKey(propertyName.toLowerCase())) {
message += " (fields/setters are case sensitive!)";
}
if (this.throwOnUnknownProperties) {
throw new DatabaseException(message);
} else if (this.warnOnUnknownProperties) {
logger.warn(message);
if (this.throwOnUnknownProperties || this.warnOnUnknownProperties) {
String message =
"No setter/field for "
+ propertyName
+ " found "
+ "on class "
+ this.clazz.getName();
if (this.properties.containsKey(propertyName.toLowerCase())) {
message += " (fields/setters are case sensitive!)";
}
if (this.throwOnUnknownProperties) {
throw new DatabaseException(message);
} else if (this.warnOnUnknownProperties) {
logger.warn(message);
}
Comment on lines +745 to +747
Copy link

@gemini-code-assist gemini-code-assist bot Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this block is already guarded by if (this.throwOnUnknownProperties || this.warnOnUnknownProperties), the check for this.warnOnUnknownProperties in the else if is redundant. If this.throwOnUnknownProperties is false, this.warnOnUnknownProperties must be true for the outer condition to have been met. You can simplify this to a simple else block for better readability.

Suggested change
} else if (this.warnOnUnknownProperties) {
logger.warn(message);
}
} else {
logger.warn(message);
}

}
}
}
Expand Down
Loading