Skip to content

⚡ Avoid unnecessary String construction in CustomClassMapper#1182

Open
lahirumaramba wants to merge 1 commit intomainfrom
perf-custom-class-mapper-optimization-15368579983768861312
Open

⚡ Avoid unnecessary String construction in CustomClassMapper#1182
lahirumaramba wants to merge 1 commit intomainfrom
perf-custom-class-mapper-optimization-15368579983768861312

Conversation

@lahirumaramba
Copy link
Member

  • 💡 What: Wrapped the construction of the "No setter/field" error message in CustomClassMapper within a check for throwOnUnknownProperties or warnOnUnknownProperties.
  • 🎯 Why: Previously, this message was constructed (involving string concatenation and case-insensitive property lookup) even when both throwOnUnknownProperties and warnOnUnknownProperties were false (e.g., when @IgnoreExtraProperties is used). This was wasted effort inside a loop, especially when processing objects with many unknown properties.
  • 📊 Measured Improvement: Running a benchmark with 10,000 iterations of deserializing a map with 1,000 unknown properties into a bean annotated with @IgnoreExtraProperties:
    • Baseline: ~3130 ms (0.313 ms/iter)
    • Optimized: ~109 ms (0.011 ms/iter)
    • Improvement: ~28x speedup for this specific scenario.

PR created automatically by Jules for task 15368579983768861312 started by @lahirumaramba

This change optimizes the CustomClassMapper by avoiding the construction
of the "No setter/field" error message when both throwOnUnknownProperties
and warnOnUnknownProperties are false. This scenario occurs commonly
when using @IgnoreExtraProperties.

Benchmark results show a ~28x improvement for deserializing objects with
many unknown properties.

Co-authored-by: lahirumaramba <55609+lahirumaramba@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gemini-code-assist
Copy link

Summary of Changes

Hello @lahirumaramba, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the CustomClassMapper by conditionally constructing error messages related to unknown properties. Previously, these messages were built even when they would not be used, causing unnecessary overhead. The change ensures that string concatenation and case-insensitive property lookups only occur when an error or warning is actually going to be thrown or logged, significantly improving performance in scenarios where unknown properties are ignored.

Highlights

  • Avoided unnecessary String construction: Wrapped the construction of the "No setter/field" error message in CustomClassMapper within a check for throwOnUnknownProperties or warnOnUnknownProperties.
  • Performance Improvement: Eliminated wasted effort of constructing error messages when both throwOnUnknownProperties and warnOnUnknownProperties are false, leading to a ~28x speedup in specific scenarios involving deserializing objects with many ignored unknown properties.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/main/java/com/google/firebase/database/utilities/encoding/CustomClassMapper.java
    • Optimized error message construction logic to prevent unnecessary string operations when throwOnUnknownProperties and warnOnUnknownProperties are false.
Activity
  • Pull request was automatically created by Jules for a task started by @lahirumaramba.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a valuable performance optimization by avoiding unnecessary error message construction in CustomClassMapper when unknown properties are ignored. The change is logical and effectively addresses the performance issue described. I have one minor suggestion to simplify the conditional logic for improved readability and to remove a redundant check.

Comment on lines +745 to +747
} else if (this.warnOnUnknownProperties) {
logger.warn(message);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since this block is already guarded by if (this.throwOnUnknownProperties || this.warnOnUnknownProperties), the check for this.warnOnUnknownProperties in the else if is redundant. If this.throwOnUnknownProperties is false, this.warnOnUnknownProperties must be true for the outer condition to have been met. You can simplify this to a simple else block for better readability.

Suggested change
} else if (this.warnOnUnknownProperties) {
logger.warn(message);
}
} else {
logger.warn(message);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments