Skip to content

Do not run 'bundle migrate' tests twice #4539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
denik merged 1 commit into from
Feb 18, 2026
Merged

Do not run 'bundle migrate' tests twice #4539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/basic/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions acceptance/bundle/migrate/basic/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export DATABRICKS_BUNDLE_ENGINE=
Copy link
Contributor

@andrewnester andrewnester Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why setting it to empty value instead of unsetting?

Copy link
Contributor Author

@denik denik Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason, unsetting would also work.

# Migrating without state, should print a message about missing state.
trace musterr $CLI bundle deployment migrate

Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/dashboards/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/default-python/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions acceptance/bundle/migrate/default-python/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export DATABRICKS_BUNDLE_ENGINE=
trace $CLI bundle init default-python --config-file ./input.json
cd my_default_python

Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/grants/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions acceptance/bundle/migrate/grants/script
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export DATABRICKS_BUNDLE_ENGINE=
trace DATABRICKS_BUNDLE_ENGINE=terraform $CLI bundle deploy
print_state.py > out.original_state.json

Expand Down
2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/permissions/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/profile_arg/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/runas/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions acceptance/bundle/migrate/test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ Cloud = false
RecordRequests = true
IncludeRequestHeaders = ["User-Agent"]
Ignore = [".databricks"]

# All tests explicitly set DATABRICKS_BUNDLE_ENGINE, so there is no need for matrix testing
EnvMatrix.DATABRICKS_BUNDLE_ENGINE = ["direct"]
2 changes: 1 addition & 1 deletion acceptance/bundle/migrate/var_arg/out.test.toml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading