Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: d16b713
19 interesting tests: 7 KNOWN, 7 SKIP, 4 flaky, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Feb 18, 2026
andrewnester
approved these changes
Feb 18, 2026
| @@ -1,3 +1,4 @@ | |||
| export DATABRICKS_BUNDLE_ENGINE= | |||
Contributor
There was a problem hiding this comment.
Why setting it to empty value instead of unsetting?
Contributor
Author
There was a problem hiding this comment.
No particular reason, unsetting would also work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Those tests set DATABRICKS_BUNDLE_ENGINE in the script, so execution is identical between engines, no need to run it twice. Since terraform tests take a lot longer than direct, this should reduce critical path to get PR tested.