Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-version-selector-zero.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Fix CDN URL resolution for packages with `0.x.x` versions by returning `canary` tag instead of `0`
21 changes: 21 additions & 0 deletions packages/shared/src/__tests__/versionSelector.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,25 @@ describe('versionSelector', () => {
])('versionSelector(%s) should return %i', (version, expected) => {
expect(versionSelector(undefined, version)).toEqual(expected.toString());
});

// 0.x.x versions should return 'canary' since @pkg@0 doesn't resolve properly on the CDN
test.each([
['0.0.1', 'canary'],
['0.1.0', 'canary'],
['0.2.3', 'canary'],
['v0.0.1', 'canary'],
[' 0.0.1 ', 'canary'],
])('versionSelector(%s) should return canary for 0.x versions', (version, expected) => {
expect(versionSelector(undefined, version)).toEqual(expected);
});

// 0.x.x versions with prerelease tags should still use the prerelease tag
test.each([
['0.0.1-next.0', 'next'],
['0.1.0-alpha.1', 'alpha'],
['0.2.3-beta.5', 'beta'],
['0.0.1-snapshot.0', '0.0.1-snapshot.0'],
])('versionSelector(%s) should return prerelease tag for 0.x prerelease versions', (version, expected) => {
expect(versionSelector(undefined, version)).toEqual(expected);
});
});
6 changes: 5 additions & 1 deletion packages/shared/src/versionSelector.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,8 @@ const getPrereleaseTag = (packageVersion: string) =>
.replace(/^v/, '')
.match(/-(.+?)(\.|$)/)?.[1];

export const getMajorVersion = (packageVersion: string) => packageVersion.trim().replace(/^v/, '').split('.')[0];
export const getMajorVersion = (packageVersion: string) => {
const major = packageVersion.trim().replace(/^v/, '').split('.')[0];
// For 0.x.x versions, use canary since @pkg@0 doesn't resolve properly on the CDN
return major === '0' ? 'canary' : major;
};
Loading