fix(shared): Use canary tag for 0.x.x package versions#7735
fix(shared): Use canary tag for 0.x.x package versions#7735jacekradko wants to merge 2 commits intomainfrom
Conversation
When a package has a 0.x.x version, getMajorVersion was returning '0', which creates invalid CDN URLs like @clerk/ui@0 that don't resolve. This fix returns 'canary' instead for 0.x.x versions, ensuring the URL resolves to @clerk/ui@canary which works correctly.
🦋 Changeset detectedLatest commit: a1dd33c The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughUpdated version selection logic and tests: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
@clerk/agent-toolkit
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
I think it's more appropriate for this logic to live in our worker instead. |
Summary
0.x.xversions@clerk/uiis at version0.0.1,getMajorVersionwas returning"0", creating invalid CDN URLs like@clerk/ui@0/dist/ui.browser.js"canary"for0.x.xversions, so URLs resolve to@clerk/ui@canary/dist/ui.browser.jsTest plan
0.x.xversion handling0.x.xversions (e.g.,0.0.1-next.0→next)Summary by CodeRabbit