feat(p3-http): implement consume-body changes
#11653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
force-pushed
the
feat/wasip3-http-consume-body
branch
2 times, most recently
from
c933bdb to
304d730
Compare
This was referenced Sep 9, 2025
rvolosatovs
force-pushed
the
feat/wasip3-http-consume-body
branch
from
304d730 to
b7a246a
Compare
rvolosatovs
added
the
wasm-proposal:component-model-async
rvolosatovs
force-pushed
the
feat/wasip3-http-consume-body
branch
from
b7a246a to
263e690
Compare
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
feat/wasip3-http-consume-body
branch
from
263e690 to
163c277
Compare
Member
Author
|
As discussed earlier today, we're waiting for a new wasip3 RC (cc @yoshuawuyts), which will be pulled in this PR, but other than that it is ready for review |
alexcrichton
approved these changes
Sep 15, 2025
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Will hold off on merging till we sort out the rc version for WASI
* Use the 2025-09-16 tag instead of 2025-08-15. * Pulls in `wasi:http` updates "officially". * Pulls in minor `wasi:cli` updates, and that's implemented here as well.
Member
|
Ok I've pushed up an update to the official tag here plus the assorted CLI changes. @rvolosatovs or @dicej mind taking a look at my changes before merging? |
dicej
approved these changes
Sep 17, 2025
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
Sep 17, 2025
* feat(p3-http): implement `consume-body` changes Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * Update WITs to the latest snapshot * Use the 2025-09-16 tag instead of 2025-08-15. * Pulls in `wasi:http` updates "officially". * Pulls in minor `wasi:cli` updates, and that's implemented here as well. --------- Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> Co-authored-by: Alex Crichton <alex@alexcrichton.com>
alexcrichton
added a commit
that referenced
this pull request
Sep 17, 2025
* async: add stream/future producers and blanket impl for `Future` (#11684) * async: add `EmptyProducer` and blanket impl for `Future` Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * move more future/stream producers to `wasmtime` crate Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * async: allow blanket `Future` impl to trap Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * async: remove the need for `{Ready,Empty}Producer` Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> --------- Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * Fix a missing outparam write in the p1 adapter (#11702) This fixes an issue found through #11701, notably the "release mode infinite loops" behavior that was seen. The cause was when `fd_readdir` returned after skipping all directory entries it forgot to write the final `*bufused = 0` out-param in the early-exit, unlike the end of the function which already sets this. * feat(p3-http): implement `consume-body` changes (#11653) * feat(p3-http): implement `consume-body` changes Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * Update WITs to the latest snapshot * Use the 2025-09-16 tag instead of 2025-08-15. * Pulls in `wasi:http` updates "officially". * Pulls in minor `wasi:cli` updates, and that's implemented here as well. --------- Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> Co-authored-by: Alex Crichton <alex@alexcrichton.com> --------- Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> Co-authored-by: Roman Volosatovs <rvolosatovs@users.noreply.github.com>
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
* feat(p3-http): implement `consume-body` changes Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> * Update WITs to the latest snapshot * Use the 2025-09-16 tag instead of 2025-08-15. * Pulls in `wasi:http` updates "officially". * Pulls in minor `wasi:cli` updates, and that's implemented here as well. --------- Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net> Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement changes to
consume-bodyas proposed in WebAssembly/wasi-http#185 and discussed in WebAssembly/wasi-http#176As discussed on Monday, this PR will only be merged once WebAssembly/wasi-http#185 is merged and a new RC is cut