This repository was archived by the owner on Nov 25, 2025. It is now read-only.
p3: rework consume-body
#185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two gaps in current
wasi:http:{request,response}::newreturn afuture<result<_, error-code>>, but in case thatconsume-bodyis called on a request/response originating from this constructor, there is no way for the component to actually communicate a result on that future.consume-bodyis a method on request/response, but it can only be called once. That introduces complexity for the implementers and a potential hazard for the users, for example:Whether returning a response, body of which has been consumed, is valid or not is not obvious.
To address these issues:
future<result<_, error-code>>as parameter inconsume-body(see [v0.3]: Changes toconsume-body#176 for more details)consume-bodya static function moving the request/response it's called on.A note on partial body read use case:
Some implementations may want to read some data from the body, but pass along the rest.
Such use cases are enabled with a pattern as follows:
Closes #176
Wasmtime implementation: bytecodealliance/wasmtime#11653