[wasm-metadata] change the print ordering#2074
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Feb 26, 2025
Merged
[wasm-metadata] change the print ordering#2074alexcrichton merged 2 commits intobytecodealliance:mainfrom
alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
alexcrichton
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing too fancy here, this changes the print ordering of the
wasm-metadatatable to print the "kind" and "range" together at the start, and "language" as the first item of the producers section. I was looking at the output in bytecodealliance/cargo-component#372 last week, and felt like the fields would benefit from a slight reordering.I'm still hopeful that Nukesor/comfy-table#160 will eventually be implemented, enabling us to lift the
name,kind, andrangefields into a separate title bar. But until then I figured it would be good to group them together at the start of the table. Withrangebeforename, so that if fields likedescription,license, and so on exist they are all grouped together.Thanks!
Example