[wasm-metadata] print relationships#2075
Conversation
pchickey
left a comment
There was a problem hiding this comment.
Thanks, looks great. Sorry to bikeshed but is it possible to move the name to the top row in these tables? That would make it clearer to me what I am looking at when I see multiple tables.
|
As far as the increased complexity of this information, one approach with precedent is to optionally emit json so that users can use tools like |
Yep, for sure! Also: no need to apologize; I've been redecorating the communal bike shed in these PRs. This is a good time to chime in on what color to paint it.
There is already a json option for that from the command line. That probably does buy us some space to experiment with the human-readable interface. Let's see what is possible here. |
1e8856d to
88b50bf
Compare
Sibling to #2074, this adds child relationships to the printed output of
wasm-metadata. This should make it easier to understand what the relationship is between the various payloads in the binary.On a quick aside here: together with #2058 and #1924 we're on track to significantly increase the amount of data printed by
wasm-metadata. I don't think this is a bad thing per se - all of this info is useful. But we may want to rethink exactly how we're printing that data in the longer term. Perhaps by providing summary tables, or separate commands to drill down into specifics, and so on. Nothing to do here now, but I wanted to acknowledge that this will eventually become a concern.Thanks!
Example