Fix SMAA resources not being cleaned up

[kristoff3r]

Objective

Fixes #22963

Solution

Remove derived resources for SMAA in the render world when the Smaa component is removed, so the view query doesn't keep running.

As a follow-up, we should add something equivalent to this as an option to the ExtractComponent macro.

Testing

Check that the problem with cargo run --example anti_aliasing and moving between AA modes.

[kristoff3r]

This is in draft until someone confirms that it actually solves the problem.

[atlv24]

This fixes it for me.

[mockersf]

This should work, but it feels like the introduction of a new pattern that needs more ECS discussion

It's a form of linked components that must be removed together

I would prefer to fix this directly in the anti_aliasing example for now, or at least start with the follow up discussion, and add a big todo to use the general version once its done

[kristoff3r]

This should work, but it feels like the introduction of a new pattern that needs more ECS discussion

It's a form of linked components that must be removed together

I would prefer to fix this directly in the anti_aliasing example for now, or at least start with the follow up discussion, and add a big todo to use the general version once its done

Yeah, it requires slightly more expressiveness than the extract system is currently capable of, specifically it currently doesn't handle components that are derived in the render world but are not part of extraction.

There are several other possible workarounds:

• Make the render pass query for &Smaa as well, so it doesn't run when the component has been removed (FXAA does this). That still leaves the old data hanging around though.
• Remove the ExtractComponent derive, and handle the removal during manual extraction (several other rendering systems currently do this), but that's a lot more boilerplate.

I'd prefer to add a TODO here, and then do a follow up PR that extends SyncComponent/ExtractComponent with features to solve this, and then a second follow up PR that goes through a bunch of the rendering systems and cleans the ad-hoc syncing up.

[kfc35]

This also fixes the example for me.

The plan to follow up afterwards sounds reasonable, but if things get busy, I’d suggest to make an issue from your comment so it’s not lost / someone else can continue the vision