Skip to content

Conversation

@Kyujenius
Copy link
Contributor

🎯 Changes

Add test Coverage for the evaluate utility function - Map and Set comparison logic.

Test cases added:

  • Map equality: equal maps, empty maps, different sizes, different keys, different values
  • Set equality: equal sets, empty sets, different sizes, different values

This improves utils.ts statement coverage from 90.34% to 97.15%.

AS-IS TO-BE
image image

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Add tests for the evaluate utility function to cover Map and Set
comparison logic, including edge cases for equality, empty collections,
different sizes, and different values.
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2026

⚠️ No Changeset found

Latest commit: 0be8209

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Jan 29, 2026

View your CI Pipeline Execution ↗ for commit 0be8209

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 53s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-29 11:54:37 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 29, 2026

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@2009

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@2009

@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@2009

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@2009

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@2009

@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@2009

@tanstack/react-form-nextjs

npm i https://pkg.pr.new/@tanstack/react-form-nextjs@2009

@tanstack/react-form-remix

npm i https://pkg.pr.new/@tanstack/react-form-remix@2009

@tanstack/react-form-start

npm i https://pkg.pr.new/@tanstack/react-form-start@2009

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@2009

@tanstack/solid-form-devtools

npm i https://pkg.pr.new/@tanstack/solid-form-devtools@2009

@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@2009

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@2009

commit: 0be8209

@sentry
Copy link

sentry bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (6892ed0) to head (0be8209).
⚠️ Report is 127 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2009      +/-   ##
==========================================
- Coverage   90.35%   89.96%   -0.39%     
==========================================
  Files          38       48      +10     
  Lines        1752     1953     +201     
  Branches      444      491      +47     
==========================================
+ Hits         1583     1757     +174     
- Misses        149      179      +30     
+ Partials       20       17       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kyujenius
Copy link
Contributor Author

@LeCarbonator
I noticed some files in form-core have room for improved test coverage. I'd like to study the codebase more and contribute additional test PRs if that would be helpful. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant