Ubuntu Xenial Warning: Block python3.6 PPA installation waiting on user's agreement #681
Conversation
| echo "Alternatively we'll try to add 3rd party python3.6 APT repository: https://launchpad.net/~deadsnakes/+archive/ubuntu/ppa." | ||
| echo "By continue you're aware of security risk associated with using unofficial 3rd party PPA repository." | ||
| echo "" | ||
| read -p "Press [y] to continue or [n] to cancel adding it: " choice |
There was a problem hiding this comment.
I decided to not provide a dedicated installation flag for Ubuntu Xenial installer as everything could be already done with yes | or echo 'y' | from the user side anyways as answer to this [y/n] question.
There was a problem hiding this comment.
@amanda11 ^^ I believe that should answer your question about running installer in non-interactive mode.
Even if we add --install-py3-from-insecure-ppa or whatever flag for extra security, - it makes little sense as users would be able to use yes | installer or echo y | installer to answer the question in a native Linux way.
There was a problem hiding this comment.
OK - so we just need to update the E2E tests to install with an echo "y" | installer then?
Fine with me.
There was a problem hiding this comment.
Yeah that's fine with me as well.
amanda11
left a comment
amanda11
left a comment
There was a problem hiding this comment.
LGTM - just a minor comment on wording in warning.
Also, are we adding the --use-deadsnakes-repo-for-python3.6 option in under a separate PR to avoid the question?
Per previous discussion in #679, adding an option to install 3rd party PPA based on user's input.
On Ubuntu Xenial the installer would stop, show insecure warning and wait for user's input to continue: