Add extra flag for Ubuntu 16.04 to install py3 PPA automatically #682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
changed the title
Member
Author
arm4b
commented
Dec 15, 2020
Comment on lines
+142
to
+143
| echo "Press [y] to continue or [n] to cancel adding it: " | ||
| read choice |
Member
Author
There was a problem hiding this comment.
FYI in a sub-shell environment read -p "Message" choice won't show the Message and so that was moved out as echo.
amanda11
approved these changes
Dec 16, 2020
Contributor
amanda11
left a comment
amanda11
left a comment
There was a problem hiding this comment.
LGTM - good to have found the extra edge cases where it didn't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #681, this PR adds extra flag
--u16-add-insecure-py3-ppapassed to installer to add 3rd party insecure PPA with python3 under Ubuntu Xenial.This fixes more corner cases I just identified with different non-interactive modes, subshells,
curl|bashpiping and other tricky situations.