[kotlin-server][JAX-RS] Add useTags to kotlin-server JAXRS code generator#22970
Open
feczkob wants to merge 4 commits intoOpenAPITools:masterfrom
Open
[kotlin-server][JAX-RS] Add useTags to kotlin-server JAXRS code generator#22970feczkob wants to merge 4 commits intoOpenAPITools:masterfrom
useTags to kotlin-server JAXRS code generator#22970feczkob wants to merge 4 commits intoOpenAPITools:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="samples/server/petstore/kotlin-server/jaxrs-spec/README.md">
<violation number="1" location="samples/server/petstore/kotlin-server/jaxrs-spec/README.md:37">
P2: README API endpoint table now omits resource prefixes (e.g., /pet, /store, /user), producing incomplete paths and misleading documentation.</violation>
</file>
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java:788">
P2: Default useTags=false is ignored unless the option is explicitly provided, so omitted configuration falls back to tag-based grouping (useTags=true behavior), contradicting the documented default.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
.../openapi-generator/src/main/java/org/openapitools/codegen/languages/KotlinServerCodegen.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20342
@karismann @Zomzog @andrewemery @4brunu @yutaka0m @stefankoppier @e5l @dennisameling could you please take a look?
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Adds a useTags option to the kotlin-server JAXRS generator to control API grouping and class names, and computes a common path applied to class-level @path and shown in docs. Fixes #20342.
Written for commit af4d93d. Summary will update on new commits.