Skip to content

chore: a quick fix for the AVD docs #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MacMur85 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: a quick fix for the AVD docs #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/user-guides/Migrate_AVD_pools.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Here are a list of the virtual_desktop_group_active status:

- blue means only virtual desktop blue is deployed whilst virtual desktop green is removed.
- green means only virtual desktop green is deployed whilst virtual desktop blue is removed. Users are directed to group green.
- both-blue-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group green. All other users will be directed to group blue.
- both-green-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group blue. All other users will be directed to group green.
- both-with-blue-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group green. All other users will be directed to group blue.
Copy link
Contributor

@mrlockstar mrlockstar Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check in the variables.tf file as well?

variable "virtual_desktop_group_active" {
description = <<-EOT
This can either be 'blue', 'green', 'both-with-blue-primary', 'both-with-green-primary', 'both-with-blue-primary-but-equal-vms' or 'both-with-green-primary-but-equal-vms'.
blue means only virtual desktop blue is deployed whilst virtual desktop green is removed.
green means only virtual desktop green is deployed whilst virtual desktop blue is removed. Users are directed to group green.
both-blue-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group green. All other users will be directed to group blue.
both-green-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group blue. All other users will be directed to group green.
both-with-blue-primary-but-equal-vms means both virtual desktop groups are deployed with equal VM counts, but ONLY the platform users can see group green. All other users will be directed to group blue.
both-with-green-primary-but-equal-vms means both virtual desktop groups are deployed with equal VM counts, but ONLY the platform users can see group blue. All other users will be directed to group green.

EOT

type = string

validation {
condition = contains(["blue", "green", "both-with-blue-primary", "both-with-green-primary", "both-with-blue-primary-but-equal-vms", "both-with-green-primary-but-equal-vms"], var.virtual_desktop_group_active)
error_message = "The virtual_desktop_group_active variable must be blue of: 'blue', 'green', 'both-with-blue-primary', 'both-with-green-primary', 'both-with-blue-primary-but-equal-vms', 'both-with-green-primary-but-equal-vms'."
}
}

Copy link
Contributor Author

@MacMur85 MacMur85 Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked, the change I'm proposing is in line with the variables.tf and the variable validation rules.
Using the old version, before the fix, results in an error during the terraform plan.

- both-with-green-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group blue. All other users will be directed to group green.
- both-with-blue-primary-but-equal-vms means both virtual desktop groups are deployed with equal VM counts, but ONLY the platform users can see group green. All other users will be directed to group blue.
- both-with-green-primary-but-equal-vms means both virtual desktop groups are deployed with equal VM counts, but ONLY the platform users can see group blue. All other users will be directed to group green.

Expand Down