Skip to content

Conversation

@MacMur85
Copy link
Contributor

@MacMur85 MacMur85 commented Dec 9, 2025

Description

A fix for the AVD update docs that currently has the wrong configuration for deploying both AVD host pools.

Old config:

- both-blue-primary 
- both-green-primary 

New correct config:

- both-with-blue-primary 
- both-with-green-primary 

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

- green means only virtual desktop green is deployed whilst virtual desktop blue is removed. Users are directed to group green.
- both-blue-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group green. All other users will be directed to group blue.
- both-green-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group blue. All other users will be directed to group green.
- both-with-blue-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group green. All other users will be directed to group blue.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check in the variables.tf file as well?

variable "virtual_desktop_group_active" {
description = <<-EOT
This can either be 'blue', 'green', 'both-with-blue-primary', 'both-with-green-primary', 'both-with-blue-primary-but-equal-vms' or 'both-with-green-primary-but-equal-vms'.
blue means only virtual desktop blue is deployed whilst virtual desktop green is removed.
green means only virtual desktop green is deployed whilst virtual desktop blue is removed. Users are directed to group green.
both-blue-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group green. All other users will be directed to group blue.
both-green-primary means both virtual desktop groups are deployed, but ONLY the platform users can see group blue. All other users will be directed to group green.
both-with-blue-primary-but-equal-vms means both virtual desktop groups are deployed with equal VM counts, but ONLY the platform users can see group green. All other users will be directed to group blue.
both-with-green-primary-but-equal-vms means both virtual desktop groups are deployed with equal VM counts, but ONLY the platform users can see group blue. All other users will be directed to group green.

EOT

type = string

validation {
condition = contains(["blue", "green", "both-with-blue-primary", "both-with-green-primary", "both-with-blue-primary-but-equal-vms", "both-with-green-primary-but-equal-vms"], var.virtual_desktop_group_active)
error_message = "The virtual_desktop_group_active variable must be blue of: 'blue', 'green', 'both-with-blue-primary', 'both-with-green-primary', 'both-with-blue-primary-but-equal-vms', 'both-with-green-primary-but-equal-vms'."
}
}

Copy link
Contributor Author

@MacMur85 MacMur85 Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked, the change I'm proposing is in line with the variables.tf and the variable validation rules.
Using the old version, before the fix, results in an error during the terraform plan.

@MacMur85 MacMur85 requested a review from mrlockstar December 9, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants