Conversation
This has been discussed before, @usiems wrote:
As far as I understand, there is a consensus that a common style would be ok. |
|
The code in generator/simplecpp should be excluded from the reformatting, as this is code from an external source which might be updated again in the future. |
|
I had a look at the formatted code, and it mostly looks good to me (with a couple of things that I probably would like to change in the config). |
🙏 I am now working on this and you should expect a series of targeted pull requests 🚀 |
|
@MinyazevR - I see that you are closing all your PRs - are you giving up on this, or is there a technical reason? |
|
@mrbean-bremen In term of backport, I have done everything i wanted to. Thanks for checking in. The remaining parts will be relates to CMake support and can definitely be done afterwards. Regarding clang, I suggest you exclude the |
|
@mrbean-bremen |
This
PRaims to addClangFormattoPythonQt. During the discussion, it was decided thatclang-formatis a valid solution.A version of
clang-format-20or higher is required, and a testing script (run-clang-format.sh) has been written for testing and/or running inCI.It is worth noting that the
PythonQt Generatorhas a style that differs from the mainsrcdirectory. If this is a priority, you can put a separate.clang-formatin thegeneratordirectory, which will override the parent one.The following steps:
run-clang-format.shlocallyPR(possibly changing some.clang-formatparameters)CI