addDecorators: Check for null object#290
Merged
mrbean-bremen merged 1 commit intoMeVisLab:masterfrom Sep 1, 2025
Merged
Conversation
This prevents potential crashes or undefined behavior when a null object is passed to the method. (cherry picked from commit commontk/PythonQt@751ec46)
Comment on lines
+1563
to
+1566
| if (o == nullptr) | ||
| { | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
The formatting does not match the rest of the code. I will merge as is to avoid further merge problems - at some point, when the merges are done, #265 will be merged in some form, would be good to synchronize this with the commontk version then.
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out. And very soon, the commontk fork will be aligned with upstream 🤞
mrbean-bremen
approved these changes
Sep 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents potential crashes or undefined behavior when a null object is passed to the method.
Note
For reference, those patches were developed in the context of the
commontk/PythonQtfork.Cherry picked from commits commontk/PythonQt@751ec46a3