Skip to content

Conversation

@JamesDo-vfx
Copy link

use Lab Imposter Texture to be able to read in redshift houdini

@mx-gbolton
Copy link
Contributor

Hello, are you the shader author? We require source files in this repository to have an open source license statement. The vast majority are using Apache 2.0, with some MIT, BSD 3 and CC BY-NC-SA.

Some style points for correction:

  • Correct spelling is "Impostor", not "Imposter", right?
  • Doesn't seem Redshift-specific, so no need to use RS in the shader name
  • Avoid underscores in file names -- ImpostorBillboard.osl would be better - image name should match
  • Shader name ideally is the same as the source file name
  • Entries in the README should be in alphabetical order

If you have a better example image showing shader with the flipbook texture, it might be more useful to see at a glance what the shader is about. If not, someone here can cook one up.

@JamesDo-vfx
Copy link
Author

I am the author of the shader and I have modified the requirements you mentioned, I am not sure if it is possible to add gif images instead of images. Can you please take a look ?

@JamesDo-vfx
Copy link
Author

Hi, I have edited the code as best as I can based on my knowledge, can you please check if the code is up to the standard to be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants