This repository was archived by the owner on Oct 12, 2020. It is now read-only.
Tyler Domanski Major Project Magic Mirror #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamZallan
suggested changes
Apr 11, 2018
| --- | ||
| This project is the design, manufacturing and assembly of a Magic Mirror. | ||
| A magic mirror is a device that utilizes a two-way mirror and a monitor to display information on a screen while still reflecting an image with a much better quality than just using a camera could provide. | ||
| The mirror measures “_” x “_” and was created over the course of a month. |
Member
There was a problem hiding this comment.
I assume you want to put actual dimensions instead of “_” x “_”.
| This project is the design, manufacturing and assembly of a Magic Mirror. | ||
| A magic mirror is a device that utilizes a two-way mirror and a monitor to display information on a screen while still reflecting an image with a much better quality than just using a camera could provide. | ||
| The mirror measures “_” x “_” and was created over the course of a month. | ||
| The mirror also utilizes a raspberry pi to run control the mirror and uses Raspbian OS. The raspberry pi is running an open-source, modular, smart mirror platform called MagicMirror2. |
Member
There was a problem hiding this comment.
Maybe capitalize Raspberry Pi like you do with Raspbian OS
| date: 2018-04-10 9:25:00 | ||
| categories: | ||
| -projects | ||
| Description: A helpful mirror that displays useful information to the user. |
Member
There was a problem hiding this comment.
Can you make these YAML keys lowercase?
| categories: | ||
| -projects | ||
| Description: A helpful mirror that displays useful information to the user. | ||
| Image: |
Member
There was a problem hiding this comment.
Can you add photos to this post, especially in the YAML?
| author-bio:1st Year Electrical Mechanical Engineering Technologies Major at Rochester Institute of Technology. | ||
| Author-email: tjd2490@g.rit.edu | ||
| author-social: | ||
| github: |
Member
There was a problem hiding this comment.
If you aren't linking to your social accounts, you can remove these attributes.
mfrancis95
reviewed
Apr 16, 2018
|
|
||
|
|
||
| The mirror currently displays compliments, important news, the weather, the time and a calendar. | ||
| These basic features give the mirror a elegant look that compliments the stained wood acting as a frame. |
Contributor
There was a problem hiding this comment.
s/a elegant/an elegant/
s/that compliments/that complements/
Member
|
In addition to the requested reviews, can you bump the date up (both in the filename and the metadata)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.