chore: regenerate ts schemas #583

ymc9 · 2026-01-09T09:45:46Z

Summary by CodeRabbit

New Features
- Added ExistsArgs type support across all entities for existence queries, enabling more precise query capabilities.
- Introduced new listPublicPosts procedure for retrieving public posts.
- Enhanced schema with expanded Post and User model relationships and additional fields.
Refactor
- Consolidated and simplified schema structure for improved readability and maintainability.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

claude · 2026-01-09T09:45:59Z

Claude finished @ymc9's task —— View job

Pull Request Review

I've completed a thorough review of the schema regeneration changes across all 10 files.

Todo List:

Analyze the regenerated schema files
Check for code quality issues in generated TypeScript
Look for potential bugs or inconsistencies
Assess security and performance implications
Provide comprehensive feedback

Review Summary

This PR contains a clean schema regeneration from ZModel schemas to TypeScript. The changes are machine-generated and follow expected patterns.

Code Quality ✅

Positive aspects:

All generated files include proper header warnings about not modifying manually
Consistent ESLint disables (/* eslint-disable */) for generated code
Proper TypeScript type imports and exports throughout
Consistent naming patterns for all type aliases

Main Changes Identified:

Added ExistsArgs types - New ExistsArgs type imports and exports for all models (e.g., UserExistsArgs, PostExistsArgs)
Import formatting standardization - Multi-line imports collapsed to single lines for consistency
Schema definition updates - Simplified attribute structures in schema definitions

Potential Issues & Recommendations

Code Quality Issues: None Found ✅

Generated TypeScript is syntactically correct
Type definitions follow proper patterns
No TypeScript compilation errors expected

Potential Bugs: None Found ✅

All model types are properly defined
Type parameters are correctly applied
Import/export chains are consistent across files

Security Considerations: Safe ✅

Generated files don't expose sensitive data
No hardcoded secrets or credentials
Follows defensive coding patterns with proper typing

Performance Implications: Positive ✅

Single-line imports reduce file size and parsing overhead
Addition of ExistsArgs types improves type safety for existence checks
Generated types enable better TypeScript optimizations

Test Coverage Assessment

Strengths:

Changes cover multiple test scenarios (basic, auth-type, default-auth)
Real-world schema compatibility validated (cal.com, formbricks, trigger.dev)
Both simple (SvelteKit sample) and complex schemas included

Areas that may need attention:

Generated types should be validated with actual test runs to ensure runtime compatibility
Consider adding type-only tests to verify TypeScript inference works correctly

Recommendations

✅ Approve for merge - This is a routine schema regeneration with expected improvements
💡 Consider running tests - Validate that the new ExistsArgs types work correctly in runtime scenarios
🔄 Document changes - If the ExistsArgs addition is a new feature, consider updating relevant documentation

Conclusion

This is an excellent schema regeneration that:

Adds new functionality (ExistsArgs types)
Improves code consistency (import formatting)
Maintains backward compatibility
Follows all established patterns

Recommendation: ✅ APPROVE

coderabbitai · 2026-01-09T09:46:00Z

📝 Walkthrough

Walkthrough

This change adds ExistsArgs type support across the codebase, restructures schema definitions from verbose to inline representations, consolidates type imports, and removes certain aggregate utilities. The updates span generated input files and sample schema definitions with no runtime behavior changes.

Changes

Cohort / File(s)	Summary
Schema restructuring in SvelteKit sample `samples/sveltekit/src/zenstack/schema.ts`, `samples/sveltekit/src/zenstack/schema-lite.ts`	Transitioned from verbose, multi-line model definitions to consolidated inline declarations; added provider, authType, procedures, and plugins members; expanded User and Post models with additional fields and relations
Type export consolidation in SvelteKit input `samples/sveltekit/src/zenstack/input.ts`	Consolidated imports, converted type signatures to single-line form, and removed CountArgs/AggregateArgs/GroupByArgs exports for User and Post entities
ExistsArgs type exports across test files `tests/e2e/apps/rally/zenstack/input.ts`, `tests/e2e/github-repos/cal.com/input.ts`, `tests/e2e/github-repos/formbricks/input.ts`, `tests/e2e/github-repos/trigger.dev/input.ts`, `tests/e2e/orm/schemas/*/input.ts`	Added ExistsArgs import alias and new public type exports for entities to support existence checks (e.g., `export type UserExistsArgs = $ExistsArgs<$Schema, "User">` across 22–98+ entities per file)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

feat: exists operation #550 – Introduces the exists operation and ExistsArgs type; these additions directly extend that feature across generated files.
fix(type-check): try improving type checking performance #475 – Refactors schema export structure (moving to export const schema = new SchemaType()); this PR applies similar consolidation patterns to schema definitions.
refactor: rename runtime package to orm #332 – Renaming of imports from @zenstackhq/runtime to @zenstackhq/orm; overlaps with import updates across generated files.

Poem

🐰 A hop through types, both old and new,
ExistsArgs bloom in every view,
Schemas shrink from lines to one,
The refactoring race is won!
With tidy imports, consolidated care,
Our code's more elegant everywhere! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title 'chore: regenerate ts schemas' accurately reflects the main purpose of the changeset, which involves regenerating TypeScript schema files across multiple directories.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9033211 and 793eb75.

📒 Files selected for processing (10)

samples/sveltekit/src/zenstack/input.ts
samples/sveltekit/src/zenstack/schema-lite.ts
samples/sveltekit/src/zenstack/schema.ts
tests/e2e/apps/rally/zenstack/input.ts
tests/e2e/github-repos/cal.com/input.ts
tests/e2e/github-repos/formbricks/input.ts
tests/e2e/github-repos/trigger.dev/input.ts
tests/e2e/orm/schemas/auth-type/input.ts
tests/e2e/orm/schemas/basic/input.ts
tests/e2e/orm/schemas/default-auth/input.ts

🧰 Additional context used

📓 Path-based instructions (1)

tests/e2e/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

E2E tests should validate real-world schema compatibility with established projects

Files:

tests/e2e/orm/schemas/auth-type/input.ts
tests/e2e/orm/schemas/basic/input.ts
tests/e2e/orm/schemas/default-auth/input.ts
tests/e2e/github-repos/formbricks/input.ts
tests/e2e/apps/rally/zenstack/input.ts
tests/e2e/github-repos/cal.com/input.ts
tests/e2e/github-repos/trigger.dev/input.ts

🧠 Learnings (8)

📓 Common learnings

Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to **/*.zmodel : ZModel schema files should define database structure and policies that compile to TypeScript via `zenstack generate`

Learnt from: CR
Repo: zenstackhq/zenstack-v3 PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-26T01:55:04.540Z
Learning: Applies to **/*.zmodel : Always run `zenstack generate` after modifying ZModel schemas