Removed debug print and fixed bug in 151#3
Open
imolein wants to merge 2 commits intozeitgeist87:masterfrom
Open
Removed debug print and fixed bug in 151#3imolein wants to merge 2 commits intozeitgeist87:masterfrom
imolein wants to merge 2 commits intozeitgeist87:masterfrom
Conversation
imolein
commented
Jun 1, 2018
imolein
commented
- Removed the print in line 96, because I guess it was added only for debugging.
- catch return value from s:send() in line 151, so if an error appears the if condition will trigger in line 152
I guess it was added for debugging reasons in commit 2126f92.
The if cond at 152 was not previously triggered if s:send() failed, because the value of err was not catched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.